Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move the "Add Category" button to the "Category" context menu to preserve vertial space #2051

Closed
2 tasks done
MikesGlitch opened this issue Dec 8, 2023 · 3 comments
Labels
feature This issue is a feature request needs votes Please upvote this feature request if you would like to see it implemented!

Comments

@MikesGlitch
Copy link
Contributor

MikesGlitch commented Dec 8, 2023

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

Removing the button from below the budget table to the Category menu will preserve vertical space and can prevent users from having to scroll to see their whole budget.

Currently, this is all dead space
image

We have a category menu, and I think it makes sense to add this "Add Category Group" functionality to it.

Describe your ideal solution to this problem

I'd like to see the "Add Group" button moved from here:

image

to be the first item in this menu here:

image

Teaching and learning

No response

@MikesGlitch MikesGlitch added the feature This issue is a feature request label Dec 8, 2023
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

✨ Thanks for sharing your idea! ✨

This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesn’t mean we don’t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).

The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+

Don’t forget to upvote the top comment with 👍!

@github-actions github-actions bot closed this as completed Dec 8, 2023
@youngcw
Copy link
Member

youngcw commented Dec 8, 2023

This would at least be more consistent with the way categories are added

@MikesGlitch
Copy link
Contributor Author

MikesGlitch commented Dec 9, 2023

I've gone and implemented this, and it looks like this:
desktop

mobile

I'll note here that it didn't actually save any vertical space due to a hard-coded pixel height to separate the income from the budget. I think it could be reduced by about 20px and have enough space, but I haven't done that in the image above. EDIT: I've done it in the PR

Open for feedback - demo link in the PR - #2057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request needs votes Please upvote this feature request if you would like to see it implemented!
Projects
None yet
Development

No branches or pull requests

2 participants