Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dark Mode - Drop Down Menu Colours #2019

Closed
1 task done
rich-howell opened this issue Dec 3, 2023 · 5 comments
Closed
1 task done

[Bug]: Dark Mode - Drop Down Menu Colours #2019

rich-howell opened this issue Dec 3, 2023 · 5 comments
Labels
bug Something isn't working theme Bugs/Features related to themes or colors

Comments

@rich-howell
Copy link
Contributor

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

If we look at the date picker it has a nice background

image

Payee & Category pickers in the transaction ledger dont have the same background

image

The purple is hard to read as is the green for the category split with the background being so light.

What error did you receive?

No error but possibly an Aa warning.

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

@rich-howell rich-howell added the bug Something isn't working label Dec 3, 2023
@youngcw youngcw added the theme Bugs/Features related to themes or colors label Dec 6, 2023
@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

I agree with making these consistent. The question then becomes do we change the date one to match the autoComplete or vice versa? In light theme they match but they are opposite coloring to the pagebackground where every other menu dropdown background is a lighter color. If we want to follow that idea then these should both be lighter color and all other menus should be darker (closer to page background).

@youngcw
Copy link
Member

youngcw commented Dec 8, 2023

I think the month picker style looks the nicest. Plus we get some more common ground between light mode to feel more connected.

@rich-howell
Copy link
Contributor Author

I agree with making these consistent. The question then becomes do we change the date one to match the autoComplete or vice versa? In light theme they match but they are opposite coloring to the pagebackground where every other menu dropdown background is a lighter color. If we want to follow that idea then these should both be lighter color and all other menus should be darker (closer to page background).

The dark background looks better, taken from the date picker, it is also easier to read, the light background is really hard to read and would need work to get the text into a decent state.

@carkom
Copy link
Contributor

carkom commented Dec 9, 2023

fixed by #2048

@rich-howell
Copy link
Contributor Author

fixed by #2048

In my opinion, that is loads better

Before:

image

After:

image

@youngcw youngcw closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme Bugs/Features related to themes or colors
Projects
None yet
Development

No branches or pull requests

3 participants