Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dark Mode - Upcoming pill wrong colour #2013

Closed
1 task done
rich-howell opened this issue Dec 3, 2023 · 4 comments
Closed
1 task done

[Bug]: Dark Mode - Upcoming pill wrong colour #2013

rich-howell opened this issue Dec 3, 2023 · 4 comments
Labels
bug Something isn't working theme Bugs/Features related to themes or colors

Comments

@rich-howell
Copy link
Contributor

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

The upcoming transaction pill in the account register is black instead of purple as it is in the schedules screen.

Taken from accounts screen
image

Taken from schedules screen
image

What error did you receive?

None

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

@rich-howell rich-howell added the bug Something isn't working label Dec 3, 2023
@youngcw youngcw added the theme Bugs/Features related to themes or colors label Dec 6, 2023
@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

So this matches the way light theme functions. Seems like this is less a problem with darkTheme and more a problem in general. It seems they were designed this way (to not match). If we want to change it, we'd be chaning it for both light and dark themes. I'm always a fan of more consistency so you know my vote! Thoughts?

@rich-howell
Copy link
Contributor Author

So this matches the way light theme functions. Seems like this is less a problem with darkTheme and more a problem in general. It seems they were designed this way (to not match). If we want to change it, we'd be chaning it for both light and dark themes. I'm always a fan of more consistency so you know my vote! Thoughts?

Consistency over the app would be better.

@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

fixed in #2048 2048

@rich-howell
Copy link
Contributor Author

fixed in #2048 2048

To me this looks much better.

image

@youngcw youngcw closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme Bugs/Features related to themes or colors
Projects
None yet
Development

No branches or pull requests

3 participants