Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dark Mode - Note Icon Not White #2012

Closed
1 task done
rich-howell opened this issue Dec 3, 2023 · 8 comments
Closed
1 task done

[Bug]: Dark Mode - Note Icon Not White #2012

rich-howell opened this issue Dec 3, 2023 · 8 comments
Labels
bug Something isn't working theme Bugs/Features related to themes or colors

Comments

@rich-howell
Copy link
Contributor

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

On the budget screen the note icon is still black

image

What error did you receive?

None

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

@rich-howell rich-howell added the bug Something isn't working label Dec 3, 2023
@youngcw youngcw added the theme Bugs/Features related to themes or colors label Dec 6, 2023
@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

Mine are all white. Is this a problem only with MS Edge browser maybe? I've tested on Firefox and Chrome.

image

@youngcw
Copy link
Member

youngcw commented Dec 8, 2023

@carkom the note icon is only white when hovering the category. They are dark otherwise

@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

Mine are transparent when not hovered. How do I replicate it?

@youngcw
Copy link
Member

youngcw commented Dec 8, 2023

Mine are transparent when not hovered. How do I replicate it?

Do you not have any notes in your categories? The icon doesn't show at all if you don't have any notes. I guess to recreate you add some notes to some categories, then turn on dark mode

@rich-howell
Copy link
Contributor Author

Mine are all white. Is this a problem only with MS Edge browser maybe? I've tested on Firefox and Chrome.

image

Replicated in Firefox

image

@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

Mine are transparent when not hovered. How do I replicate it?

Do you not have any notes in your categories? The icon doesn't show at all if you don't have any notes. I guess to recreate you add some notes to some categories, then turn on dark mode

That was it. Thanks!

@carkom
Copy link
Contributor

carkom commented Dec 8, 2023

fixed by #2048

@rich-howell
Copy link
Contributor Author

fixed by #2048

Awesome, that is indeed fixed

image

@youngcw youngcw closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme Bugs/Features related to themes or colors
Projects
None yet
Development

No branches or pull requests

3 participants