You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
space comma format is not working in nodejs 18.18. This was found while running the tests.
The test fails when running on nodejs 18.18 or nodejs 21.x
This is caused by a nodejs's v8 update, which also brought in ICU version 73. This change to the en-ZA language (the one actual-budget uses for space-comma number format) was introduced in ICU 73 https://unicode-org.atlassian.net/browse/CLDR-16247
Versions of nodejs using ICU 72 still pass.
Likely a different space-comma locale should be used.
What error did you receive?
FAIL src/shared/util.test.ts
● utility functions › number formatting works with space-comma format
expect(received).toBe(expected) // Object.is equality
Expected: "1 234,56"
Received: "1,234.56"
69 | let formatter = getNumberFormat().formatter;
70 | // grouping separator space char is a non-breaking space, or UTF-16 \xa0
> 71 | expect(formatter.format(Number('1234.56'))).toBe('1\xa0234,56');
| ^
72 |
73 | setNumberFormat({ format: 'space-comma', hideFraction: true });
74 | formatter = getNumberFormat().formatter;
at Object.<anonymous> (src/shared/util.test.ts:71:49)
Where are you hosting Actual?
Locally via Yarn
What browsers are you seeing the problem on?
Other
Operating System
Linux
The text was updated successfully, but these errors were encountered:
Verified issue does not already exist?
What happened?
space comma format is not working in nodejs 18.18. This was found while running the tests.
The test fails when running on nodejs 18.18 or nodejs 21.x
This is caused by a nodejs's v8 update, which also brought in ICU version 73. This change to the en-ZA language (the one actual-budget uses for space-comma number format) was introduced in ICU 73 https://unicode-org.atlassian.net/browse/CLDR-16247
Versions of nodejs using ICU 72 still pass.
Likely a different space-comma locale should be used.
What error did you receive?
Where are you hosting Actual?
Locally via Yarn
What browsers are you seeing the problem on?
Other
Operating System
Linux
The text was updated successfully, but these errors were encountered: