Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to flip amounts for OFX and QFX file imports #1931

Open
1 task done
KyleK1782 opened this issue Nov 19, 2023 · 2 comments
Open
1 task done

[Bug]: Unable to flip amounts for OFX and QFX file imports #1931

KyleK1782 opened this issue Nov 19, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed transaction import Related to manually importing transactions

Comments

@KyleK1782
Copy link

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When importing as a QFX of OFX there is no option to "flip amounts" which is needed when importing a credit card into an account. This option does exist for QIF and CSV.

What error did you receive?

Missing option when importing some file types.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

@KyleK1782 KyleK1782 added the bug Something isn't working label Nov 19, 2023
@joel-jeremy
Copy link
Contributor

Can you try disabling the Experimental OFX parser in the advanced setting to see if the old OFX parser's behavior is the same?

@KyleK1782
Copy link
Author

It shows the same behaviour with that option disabled.

I looked into the code when I was opening the ticket, it seems the amount flipping happens client side, not server side. Server side the ParseFileOptions doesn't include a flipAmmounts or anything like that while in loot-core you can see function parseAmountFields(...,flipAmount,...) parameter. This leads me to believe this is a client side operation.

Desktop code: https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/modals/ImportTransactions.js#L253
loot-core code: https://github.com/actualbudget/actual/blob/master/packages/loot-core/src/server/accounts/parse-file.ts#L16

@joel-jeremy joel-jeremy added the transaction import Related to manually importing transactions label Jan 6, 2024
@joel-jeremy joel-jeremy added the help wanted Extra attention is needed label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed transaction import Related to manually importing transactions
Projects
None yet
Development

No branches or pull requests

2 participants