Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cant change amount sign from negative in schedule on firefox #1922

Closed
1 task done
youngcw opened this issue Nov 17, 2023 · 2 comments · Fixed by #1992
Closed
1 task done

[Bug]: Cant change amount sign from negative in schedule on firefox #1922

youngcw opened this issue Nov 17, 2023 · 2 comments · Fixed by #1992
Labels
bug Something isn't working

Comments

@youngcw
Copy link
Member

youngcw commented Nov 17, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When setting up or editing a schedule in firefox the amount cant be changed to positive. It works fine in Chrome browsers. If you click it, nothing happens when it should change between '-' and '+'.

What error did you receive?

no error, it just doesn't work

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

Firefox

Operating System

None

@youngcw youngcw added the bug Something isn't working label Nov 17, 2023
@miqh
Copy link
Contributor

miqh commented Nov 18, 2023

Here's a snippet of interest:

Firefox is (correctly, IMO) respecting the disabled state of the sign toggling button.

On the other hand, Chromium appears to trigger the pointer-related event handlers irrespective of disabled.

focused is also a prop to the AmountInput and it's never changed.

When the sign toggle button is forcefully enabled, interaction looks like this:

1

I'm unsure what the best intervention here is, especially since EditSchedule doesn't appear to maintain a focused state.

@bakoff44
Copy link

bakoff44 commented Nov 29, 2023

I have the same problem too, on Firefox 120.0 (64-bit).

Also, typing "+123" in the field makes the app totally crashing, with the single following line of log :

k@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62089 C@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:187:62338 w@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19632 5291/S/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:19764 v@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:186:105362 i2@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:64289 aQ@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:76085 sF@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:118360 sD@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113204 sj@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:113132 sE@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:112984 sp@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:109296 sy@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:110118 oI@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:47882 33936/sf/<@https://actual.mysite.fr/static/js/main.fd0bdfe2.js:37:107617

My docker container did not returned any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants