Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Node version error for the API package #1903

Closed
MatissJanis opened this issue Nov 12, 2023 · 0 comments · Fixed by #1934
Closed

[Maintenance] Node version error for the API package #1903

MatissJanis opened this issue Nov 12, 2023 · 0 comments · Fixed by #1934
Labels
API Issues with the @actual-app/api package maintenance Related to making the project easier to maintain
Milestone
v23.12.0

Comments

@MatissJanis
Copy link
Member

MatissJanis commented Nov 12, 2023 •
edited
Loading

Minimum supported Node version is currently v18.

Some people use the API package with older node versions and then report the API package as broken.

We should add a node version check to the API package. If node version is older than the supported - print a friendly error message.
@MatissJanis MatissJanis added help wanted Extra attention is needed maintenance Related to making the project easier to maintain API Issues with the @actual-app/api package labels Nov 12, 2023
@Marethyu1 Marethyu1 mentioned this issue Nov 20, 2023
Merged
@MatissJanis MatissJanis reopened this Nov 20, 2023
@github-actions github-actions bot removed the help wanted Extra attention is needed label Nov 20, 2023
@MatissJanis MatissJanis added this to the v23.12.0 milestone Nov 22, 2023
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 27, 2023
@Marethyu1
Validate node version is >=18
9e59948 
for actual-app/api

This was done as part of actualbudget#1903
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 27, 2023
@Marethyu1
Validate node version is >=18
288f780 
for actual-app/api

This was done as part of actualbudget#1903
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 27, 2023
@Marethyu1
Validate node version is >=18.12
1284507 
for actual-app/api

This was done as part of actualbudget#1903
@Marethyu1 Marethyu1 mentioned this issue Nov 27, 2023
Merged
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 28, 2023
@Marethyu1
Validate node version is >=18
57d25e5 
for actual-app/api

This was done as part of actualbudget#1903
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 28, 2023
@Marethyu1
Validate node version is >=18
77ad7e7 
for actual-app/api

This was done as part of actualbudget#1903
Marethyu1 added a commit to Marethyu1/actual that referenced this issue Nov 28, 2023
@Marethyu1
Validate node version is >=18.12
8117041 
for actual-app/api

This was done as part of actualbudget#1903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Issues with the @actual-app/api package maintenance Related to making the project easier to maintain
Projects
None yet
Milestone
v23.12.0
Development

Successfully merging a pull request may close this issue.

Specify minimum node version for @actual-app/api nom package Marethyu1/actual
1 participant
@MatissJanis