Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Dark Theme - global notifications are not included in themes #1807

Closed
1 task done
carkom opened this issue Oct 16, 2023 · 2 comments · Fixed by #1798
Closed
1 task done

[Bug]: Dark Theme - global notifications are not included in themes #1807

carkom opened this issue Oct 16, 2023 · 2 comments · Fixed by #1798
Labels
bug Something isn't working

Comments

@carkom
Copy link
Contributor

carkom commented Oct 16, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

global notifications are not changed by themes. Anything other than light themes are set to "transparent"
image

image

What error did you receive?

No response

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Firefox, Chrome

Operating System

Windows 10
@carkom carkom added the bug Something isn't working label Oct 16, 2023
@carkom
Copy link
Contributor Author

carkom commented Oct 31, 2023

fixed by #1798

@carkom carkom mentioned this issue Nov 8, 2023
Merged
@carkom carkom linked a pull request Nov 8, 2023 that will close this issue
Warning Color Consolidations #1798
Merged
@joel-jeremy
Copy link
Contributor

Closing this as PR with the fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warning Color Consolidations carkom/actual
2 participants
@joel-jeremy @carkom