Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Goals: Templates applying full amount when full amount is already budgeted #1771

Closed
1 task done
JazzaG opened this issue Oct 8, 2023 · 10 comments
Closed
1 task done
Labels
bug Something isn't working goal templates Related to the experimental goal templates feature

Comments

@JazzaG
Copy link

JazzaG commented Oct 8, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

Applying budget templates will apply the full amount of the template if the category has greater than or equal to the full amount of the template.

For example, a schedule for an annual charge is $1400. The budget category for this charge has $1500 in the balance. Applying the template for this category adds $1400 to the budget, bringing the balance to $2900. The expected behaviour is that applying the template applies $0 to the budget category as the category already has the required amount.

Server & Client version v23.10.0

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

@JazzaG JazzaG added the bug Something isn't working label Oct 8, 2023
@youngcw
Copy link
Member

youngcw commented Oct 8, 2023

Is it specifically the schedule template that is doing this or are other templates also not working as expected?

@JazzaG
Copy link
Author

JazzaG commented Oct 8, 2023

Seems like it's just schedules.

I just tried with #template $50 by 2024-01:
October, applied template, budgeted $12.50, balance $12.50
November, manually budgeted $60, balance $72.50
December, applied template, budgeted $0, balance $72.50

@happybikes
Copy link

I'm also having the same issue with the "up to" template. I.e. #template up to 50 budgets $50 this month and $50 next month for a total of $100. It should be capping it at $50, correct?

@youngcw
Copy link
Member

youngcw commented Nov 15, 2023

@happybikes Im not able to replicate your issue at all. Do you have an example budget or steps to make this happen?

@happybikes
Copy link

@happybikes Im not able to replicate your issue at all. Do you have an example budget or steps to make this happen?

Eating Out

Something like this. It should be capping it at $160 for the subsequent month, no? Even after clicking apply budget template, it doesn't.

@youngcw
Copy link
Member

youngcw commented Nov 15, 2023

You are correct that when applying the template to the second month that it should cap the balance at 160 at the time of application. Are you applying the template to both months or just the one? Ive tried to recreate this a few different ways and have been unsuccessful. Are you still seeing the issue if you use demo.actualbudget.org?

@happybikes
Copy link

I tried it on the demo like you suggested, and the demo works correctly. After messing with it some more, I believe there may be an issue with the “apply budget template” at the top of the month. It doesn’t actually apply the template correctly, whereas the individual “apply budget template” buttons of each item work when I go through and click them one by one.

@Kidglove57
Copy link

Kidglove57 commented Nov 16, 2023

I have been using an “up to” template successfully on my real life budget for a couple of months, including applying all templates at the same time. Perhaps my scenario is slightly different in that my template is along the lines of: “#template 10 up to 50”. In this instance if I have 45 available only 5 is added. Or if I have 50 available 0 is added. This always works for me as it should.

PS I have now amended my template in my real life budget to just read “#template up to 50”. I then applied all my budget templates for several months into the future. The available in this particular category never went above 50. So like @youngcw I am really sorry but I cannot reproduce what you are seeing.

@happybikes
Copy link

Thanks for doing some troubleshooting and narrowing down the issue to something on my end. I’ve got it installed in a docker container, so I may try to spin up another one and see if I can resolve it that way. If not, it’s not the end of the world to have to apply the template manually to each individual item.

@youngcw youngcw added the goal templates Related to the experimental goal templates feature label Nov 16, 2023
@youngcw
Copy link
Member

youngcw commented Feb 4, 2024

@JazzaG are you still seeing this issue in the current build? I think I'll close this off for now unless I hear back soon.

@youngcw youngcw closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working goal templates Related to the experimental goal templates feature
Projects
None yet
Development

No branches or pull requests

4 participants