Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: --color-pageTextLink on settings page hard to read in dark mode #1760

Closed
1 task done
rich-howell opened this issue Oct 5, 2023 · 4 comments · Fixed by #1765
Closed
1 task done

[Bug]: --color-pageTextLink on settings page hard to read in dark mode #1760

rich-howell opened this issue Oct 5, 2023 · 4 comments · Fixed by #1765
Labels
bug Something isn't working experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature good first issue Good for newcomers user interface Related to the user interface

Comments

@rich-howell
Copy link
Contributor

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When viewing Actual in Dark Mode as of 23.10.0 the --color-pageTextLink links are really difficult to read

image

Proposal is that these are made darker so that they are easier on the eye.

image

The above image also uses a strong weight.

What error did you receive?

None

Where are you hosting Actual?

Fly.io

What browsers are you seeing the problem on?

Microsoft Edge

Operating System

Windows 11

@rich-howell rich-howell added the bug Something isn't working label Oct 5, 2023
@Evomatic
Copy link
Contributor

Evomatic commented Oct 5, 2023

Hi @rich-howell I am interested in working on this issue, so I will take a look!

@joel-jeremy joel-jeremy added good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature labels Oct 5, 2023
@paul-ooi
Copy link

paul-ooi commented Oct 21, 2023

@Evomatic , my suggestion on when considering "what is easier on the eyes" is look at using webAim's color checker (https://webaim.org/resources/contrastchecker/). To ensure the foreground and background pairing pass (AA) for the size that this text is at. This way it's "easier on the eyes" for more people.

@Evomatic
Copy link
Contributor

@Evomatic , my suggestion on when considering "what is easier on the eyes" is look at using webAim's color checker (https://webaim.org/resources/contrastchecker/). To ensure the foreground and background pairing pass (AA) for the size that this text is at. This way it's "easier on the eyes" for more people.

Hi @paul-ooi Thank you for sharing, I will take a look!

@carkom carkom linked a pull request Nov 8, 2023 that will close this issue
@youngcw
Copy link
Member

youngcw commented Nov 18, 2023

closing this as fixed with the updated colors.

@youngcw youngcw closed this as completed Nov 18, 2023
@github-actions github-actions bot removed the help wanted Extra attention is needed label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature good first issue Good for newcomers user interface Related to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants