Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Gocardless - Payee is empty #1588

Closed
1 task done
LasseLegarth opened this issue Aug 25, 2023 · 6 comments
Closed
1 task done

[Bug]: Gocardless - Payee is empty #1588

LasseLegarth opened this issue Aug 25, 2023 · 6 comments
Labels
bank sync Related to automatic bank syncing bug Something isn't working

Comments

@LasseLegarth
Copy link

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I've set up the GoCardless sync, and set it to import my transactions from Denmark->Handelsbanken.

It does import transactions, but I can only see the following data:

  • Date
  • Account
  • Payment/Deposit

There isn't any Payee so I have no idea what the transaction is actually about :(

I use the same GoCardless integration for firefly and the same bank/account - I get all the information about the payment there. So the data must be available, but for some reason it doesn't make it into ActualBudget

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

@LasseLegarth LasseLegarth added the bug Something isn't working label Aug 25, 2023
@MatissJanis
Copy link
Member

👋 Can you take a look at the server logs to see what data the server gets? And post a redacted version of this data here for folks to analyze.

@MatissJanis MatissJanis added the needs info We need more information from the OP before continuing label Aug 26, 2023
@LasseLegarth
Copy link
Author

👋 Can you take a look at the server logs to see what data the server gets? And post a redacted version of this data here for folks to analyze.

Yes.. I'm running it in Docker, I tried to look after a serverlog in the docker container, but failed to find anything. Where can I find this serverlog, if you can help me :) Thanks

@LasseLegarth
Copy link
Author

LasseLegarth commented Aug 26, 2023

I think I found it? 💪

{"transactionId":"STRING-ID","entryReference":"2023-07-13-12.25.04.739430","bookingDate":"2023-07-13","valueDate":"2023-08-01","transactionAmount":{"amount":"-440.06","currency":"DKK"},"additionalInformation":"MasterCard proshop.dk","balanceAfterTransaction":{"balanceAmount":{"amount":"YYY","currency":"DKK"},"balanceType":"closingBooked"},"internalTransactionId":"STR-ID"}, {"transactionId":"STRING-ID","entryReference":"2023-07-13-12.25.04.734776","bookingDate":"2023-07-13","valueDate":"2023-08-01","transactionAmount":{"amount":"-9.95","currency":"DKK"},"additionalInformation":"MasterCard NETTO H@RNING","balanceAfterTransaction":{"balanceAmount":{"amount":"YYY","currency":"DKK"},"balanceType":"closingBooked"},"internalTransactionId":"STR-ID"}]'

@MatissJanis
Copy link
Member

Great, so I can see that the payee name is in additionalInformation. It shouldn't really be there. It should be in debtorName.

There are two approaches you can take:

  1. reach out to Gocardless and report this as a bug - they have been quite quick to respond and resolve issues so far;
  2. create a new bank adapter for your bank that converts additionalInformation field to debtorName; sample how some folks have done similar things for other banks: https://github.com/actualbudget/actual-server/blob/master/src/app-gocardless/banks/american-express-aesudef1.js

@MatissJanis MatissJanis removed the needs info We need more information from the OP before continuing label Aug 27, 2023
@LasseLegarth
Copy link
Author

I got a reply from GoCardless:
`Hi Lasse,

Thank you for reaching out to us.

I have checked the data returned by Handelsbanken, and I can see that they are returning this information as "additionalInformation" thus, we we are displaying it accordingly.

We cannot assign the data to a different Datapoint as this might cause further errors down the line.

I hope this clears things up, but in case further questions arise please let me know. `

I will have to look into the bank adapter - see if I can figure out how to do that... Was hoping for a change so it just worked like it did in firefly, but fair if you don't think that is the way to go in actualbudget.

@joel-jeremy joel-jeremy added transaction import Related to manually importing transactions bank sync Related to automatic bank syncing and removed transaction import Related to manually importing transactions labels Oct 5, 2023
@MatissJanis
Copy link
Member

👋 Closing this off. Please create a new bank adapter to get this resolved.

@MatissJanis MatissJanis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bank sync Related to automatic bank syncing bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants