Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OFX Importer fails to recognize transactions in file #1007

Closed
1 task done
austempest opened this issue May 7, 2023 · 8 comments
Closed
1 task done

[Bug]: OFX Importer fails to recognize transactions in file #1007

austempest opened this issue May 7, 2023 · 8 comments
Labels
bug Something isn't working transaction import Related to manually importing transactions

Comments

@austempest
Copy link

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

A bug happened!

Imported OFX file (direct export from bank. Bank wwas ING Direct (Australia).

What error did you receive?

Import was successful, but please file a bug report and attach a redacted version of the file so we can fix our new algorithm.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 10

@austempest austempest added bug Something isn't working needs triage labels May 7, 2023
@austempest
Copy link
Author

@j-f1
Copy link
Contributor

j-f1 commented May 7, 2023

fyi @sinistersnare

@j-f1 j-f1 removed the needs triage label May 7, 2023
@j-f1
Copy link
Contributor

j-f1 commented May 7, 2023

Thank you for reporting!

@tjfinlinson
Copy link

I noticed the same thing when importing my ofx files. I'm downloading from Zions Bank in Utah. I'll try and put a redacted file up here for use as well.

@sinistersnare
Copy link
Contributor

Looking at this, it seems the old importer produced an import with 0 entries, and the new with 2. Because there was no explicit error, but only a diff, the old results were used (to ensure compatibility with past imports), and a warning was shown.

If the new importer was used, it would have succeeded as you would want. As the old results are used, you get the results you see here.

@tjfinlinson
Copy link

Looking at this, it seems the old importer produced an import with 0 entries, and the new with 2. Because there was no explicit error, but only a diff, the old results were used (to ensure compatibility with past imports), and a warning was shown.

If the new importer was used, it would have succeeded as you would want. As the old results are used, you get the results you see here.

I'm not totally sure what this means, but are you saying that since the transactions are importing nothing is broken, just giving an error (or more of a notification) to say that Actual just sees the latest import as different previous ones? Will that message always show up, or will it eventually be removed?

That makes me think something didn't happen correctly and it might not have worked 100%.

Regardless, I'm attaching a redacted file in-case it helps in any way.

Account-OFX-Transactions-Download-Redacted.txt

@sinistersnare
Copy link
Contributor

Currently there are 2 OFX importers use, the 'old' and the 'new'. In case of different results, 'old' is always used. However, in the case of this issue, 'new' would have been better.

In the future, if we remove the old parser and just use the new, this would have worked better.

@j-f1 j-f1 added the transaction import Related to manually importing transactions label May 20, 2023
@j-f1 j-f1 changed the title [Bug]: New OFX Importer: bad new parse: [Bug]: OFX Importer fails to recognize transactions in file Jun 16, 2023
@MatissJanis MatissJanis added the help wanted Extra attention is needed label Aug 26, 2023
@youngcw
Copy link
Member

youngcw commented Nov 16, 2023

closing this as outdated since we have moved to a new test importer.

@youngcw youngcw closed this as completed Nov 16, 2023
@github-actions github-actions bot removed the help wanted Extra attention is needed label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transaction import Related to manually importing transactions
Projects
None yet
Development

No branches or pull requests

6 participants