From c25e3d416327367db56828dbc3114dab31092397 Mon Sep 17 00:00:00 2001 From: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Date: Sun, 24 Nov 2024 08:43:01 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20=20Fix=20performance=20when=20na?= =?UTF-8?q?vigating=20between=20budget/accounts=20(#3882)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * memo the bindingobj * release notes * fix * a bit heavy handed * lint --- .../src/components/spreadsheet/useSheetValue.ts | 2 +- upcoming-release-notes/3882.md | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 upcoming-release-notes/3882.md diff --git a/packages/desktop-client/src/components/spreadsheet/useSheetValue.ts b/packages/desktop-client/src/components/spreadsheet/useSheetValue.ts index 692adeac566..ae0d09921ed 100644 --- a/packages/desktop-client/src/components/spreadsheet/useSheetValue.ts +++ b/packages/desktop-client/src/components/spreadsheet/useSheetValue.ts @@ -66,7 +66,7 @@ export function useSheetValue< } }, ); - }, [sheetName, bindingObj.name, bindingObj.query]); + }, [sheetName, bindingObj.name, JSON.stringify(bindingObj.query)]); return result.value; } diff --git a/upcoming-release-notes/3882.md b/upcoming-release-notes/3882.md new file mode 100644 index 00000000000..9059395e154 --- /dev/null +++ b/upcoming-release-notes/3882.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MikesGlitch] +--- + +Fix performance regression around accounts and budget pages