From 6afc149ddba9e79ed75b842650bdfef569ffd045 Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins Date: Tue, 12 Dec 2023 18:37:59 +0000 Subject: [PATCH] Improvement --- .github/workflows/e2e-test.yml | 12 +++++++++--- upcoming-release-notes/2074.md | 6 ++++++ 2 files changed, 15 insertions(+), 3 deletions(-) create mode 100644 upcoming-release-notes/2074.md diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index f8d32971ae4..d78ce5d0808 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -73,7 +73,7 @@ jobs: with: issue-number: ${{ github.event.pull_request.number }} comment-author: 'github-actions[bot]' - body-includes: visual regression tests + body-includes: VRT - name: Create comment if failed if: failure() uses: peter-evans/create-or-update-comment@v3 @@ -81,9 +81,15 @@ jobs: comment-id: ${{ steps.fc.outputs.comment-id }} issue-number: ${{ github.event.pull_request.number }} body: | - :wave: Looks like VRT (visual regression tests) are failing in this PR. This indicates a visual regression in the app. It could be either a bug in this PR or a visual change introduced by changing something. + :wave: Looks like VRT (visual regression tests) are failing in this PR. This indicates a problem in the app. It could be either a bug in this PR or a visual change introduced by changing something. - To fix this: please follow [these instructions](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/README.md#visual-regression). + To fix this: please follow [these instructions](https://github.com/actualbudget/actual/blob/master/packages/desktop-client/README.md#visual-regression) and review the output of the failing CI job to see the generated screenshots. We look forward to reviewing this PR once all the CI jobs have passed successfully! edit-mode: replace + - name: Update comment when CI job passes + if: success() && steps.fc.outputs.comment-id != '' + uses: peter-evans/create-or-update-comment@v3 + with: + comment-id: ${{ steps.fc.outputs.comment-id }} + body: The VRT tests have passed! Thank you! diff --git a/upcoming-release-notes/2074.md b/upcoming-release-notes/2074.md new file mode 100644 index 00000000000..665f73d21bb --- /dev/null +++ b/upcoming-release-notes/2074.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [MatissJanis] +--- + +ci: add helpful bot comments if CI jobs fail.