From 493f92c34a25d1fd2185201084e562a4bfcd538b Mon Sep 17 00:00:00 2001
From: carkom <neilmccreery@yahoo.com>
Date: Mon, 22 Jan 2024 23:29:32 +0000
Subject: [PATCH] revert changes

---
 .../src/components/filters/FiltersMenu.jsx    |   2 +-
 .../src/components/reports/ReportOptions.ts   |   7 +-
 .../src/components/reports/ReportSidebar.jsx  |  34 ++--
 .../src/components/reports/ReportTopbar.jsx   |  28 +--
 .../src/components/reports/SaveReport.tsx     | 178 ++++--------------
 .../src/components/reports/SaveReportMenu.tsx |  76 --------
 .../src/components/reports/SaveReportName.tsx |  72 -------
 .../reports/reports/CustomReport.jsx          |  89 +--------
 upcoming-release-notes/2257.md                |   6 -
 9 files changed, 56 insertions(+), 436 deletions(-)
 delete mode 100644 packages/desktop-client/src/components/reports/SaveReportMenu.tsx
 delete mode 100644 packages/desktop-client/src/components/reports/SaveReportName.tsx
 delete mode 100644 upcoming-release-notes/2257.md

diff --git a/packages/desktop-client/src/components/filters/FiltersMenu.jsx b/packages/desktop-client/src/components/filters/FiltersMenu.jsx
index 9c3e3aa458b..3c85a7784eb 100644
--- a/packages/desktop-client/src/components/filters/FiltersMenu.jsx
+++ b/packages/desktop-client/src/components/filters/FiltersMenu.jsx
@@ -597,7 +597,7 @@ export function AppliedFilters({
   onUpdateChange,
 }) {
   const onUpdateAppliedFilter = (filter, newFilter) => {
-    onUpdateChange?.(null, 'modify');
+    //onUpdateChange?.(null, 'modify');
     return onUpdate(filter, newFilter);
   };
 
diff --git a/packages/desktop-client/src/components/reports/ReportOptions.ts b/packages/desktop-client/src/components/reports/ReportOptions.ts
index d76a2dc02f0..3639de6a964 100644
--- a/packages/desktop-client/src/components/reports/ReportOptions.ts
+++ b/packages/desktop-client/src/components/reports/ReportOptions.ts
@@ -12,9 +12,10 @@ const startDate = monthUtils.subMonths(monthUtils.currentMonth(), 5);
 const endDate = monthUtils.currentMonth();
 const categories = useCategories();
 const selectAll: CategoryEntity[] = [];
-categories.grouped.map(categoryGroup =>
-  categoryGroup.categories &&
-  categoryGroup.categories.map(category => selectAll.push(category)),
+categories.grouped.map(
+  categoryGroup =>
+    categoryGroup.categories &&
+    categoryGroup.categories.map(category => selectAll.push(category)),
 );
 
 export const defaultReport: CustomReportEntity = {
diff --git a/packages/desktop-client/src/components/reports/ReportSidebar.jsx b/packages/desktop-client/src/components/reports/ReportSidebar.jsx
index 2ba6809de44..4dd5f8cba5f 100644
--- a/packages/desktop-client/src/components/reports/ReportSidebar.jsx
+++ b/packages/desktop-client/src/components/reports/ReportSidebar.jsx
@@ -38,10 +38,8 @@ export function ReportSidebar({
   setSelectedCategories,
   onChangeDates,
   onChangeViews,
-  onReportChange,
 }) {
   const onSelectRange = cond => {
-    onReportChange(null, 'modify');
     setDateRange(cond);
     switch (cond) {
       case 'All time':
@@ -75,7 +73,6 @@ export function ReportSidebar({
   };
 
   const onChangeMode = cond => {
-    onReportChange(null, 'modify');
     setMode(cond);
     if (cond === 'time') {
       if (customReportItems.graphType === 'TableGraph') {
@@ -106,7 +103,6 @@ export function ReportSidebar({
   };
 
   const onChangeSplit = cond => {
-    onReportChange(null, 'modify');
     setGroupBy(cond);
     if (customReportItems.mode === 'total') {
       if (customReportItems.graphType !== 'TableGraph') {
@@ -124,7 +120,7 @@ export function ReportSidebar({
   };
 
   const onChangeBalanceType = cond => {
-    onReportChange(null, 'modify');
+    //onReportChange(null, 'modify');
     setBalanceType(cond);
   };
 
@@ -256,10 +252,7 @@ export function ReportSidebar({
             id="show-empty-columns"
             checked={customReportItems.showEmpty}
             value={customReportItems.showEmpty}
-            onChange={() => {
-              setShowEmpty(!customReportItems.showEmpty);
-              onReportChange(null, 'modify');
-            }}
+            onChange={() => setShowEmpty(!customReportItems.showEmpty)}
           />
           <label
             htmlFor="show-empty-columns"
@@ -284,7 +277,6 @@ export function ReportSidebar({
             value={customReportItems.showOffBudget}
             onChange={() => {
               setShowOffBudget(!customReportItems.showOffBudget);
-              onReportChange(null, 'modify');
             }}
           />
           <label
@@ -308,10 +300,9 @@ export function ReportSidebar({
             id="show-uncategorized"
             checked={customReportItems.showUncategorized}
             value={customReportItems.showUncategorized}
-            onChange={() => {
-              setShowUncategorized(!customReportItems.showUncategorized);
-              onReportChange(null, 'modify');
-            }}
+            onChange={() =>
+              setShowUncategorized(!customReportItems.showUncategorized)
+            }
           />
           <label
             htmlFor="show-uncategorized"
@@ -358,7 +349,6 @@ export function ReportSidebar({
                 customReportItems.startDate,
                 customReportItems.endDate,
               );
-              onReportChange(null, 'modify');
             }}
           >
             Static
@@ -400,16 +390,15 @@ export function ReportSidebar({
                 From:
               </Text>
               <Select
-                onChange={newValue => {
+                onChange={newValue =>
                   onChangeDates(
                     ...validateStart(
                       allMonths,
                       newValue,
                       customReportItems.endDate,
                     ),
-                  );
-                  onReportChange(null, 'modify');
-                }}
+                  )
+                }
                 value={customReportItems.startDate}
                 defaultLabel={monthUtils.format(
                   customReportItems.startDate,
@@ -429,16 +418,15 @@ export function ReportSidebar({
                 To:
               </Text>
               <Select
-                onChange={newValue => {
+                onChange={newValue =>
                   onChangeDates(
                     ...validateEnd(
                       allMonths,
                       customReportItems.startDate,
                       newValue,
                     ),
-                  );
-                  onReportChange(null, 'modify');
-                }}
+                  )
+                }
                 value={customReportItems.endDate}
                 options={allMonths.map(({ name, pretty }) => [name, pretty])}
               />
diff --git a/packages/desktop-client/src/components/reports/ReportTopbar.jsx b/packages/desktop-client/src/components/reports/ReportTopbar.jsx
index c046fb34ee1..0704c7c8a18 100644
--- a/packages/desktop-client/src/components/reports/ReportTopbar.jsx
+++ b/packages/desktop-client/src/components/reports/ReportTopbar.jsx
@@ -14,12 +14,10 @@ import { View } from '../common/View';
 import { FilterButton } from '../filters/FiltersMenu';
 
 import { GraphButton } from './GraphButton';
-import { SaveReport } from './SaveReport';
+import { SaveReportMenuButton } from './SaveReport';
 
 export function ReportTopbar({
   customReportItems,
-  report,
-  savedStatus,
   setGraphType,
   setTypeDisabled,
   setBalanceType,
@@ -29,8 +27,6 @@ export function ReportTopbar({
   viewLabels,
   onApplyFilter,
   onChangeViews,
-  onReportChange,
-  onResetReports,
 }) {
   return (
     <View
@@ -45,7 +41,6 @@ export function ReportTopbar({
         selected={customReportItems.graphType === 'TableGraph'}
         title="Data Table"
         onSelect={() => {
-          onReportChange(null, 'modify');
           setGraphType('TableGraph');
           onChangeViews('viewLegend', false);
           setTypeDisabled([]);
@@ -63,7 +58,6 @@ export function ReportTopbar({
           customReportItems.graphType === 'StackedBarGraph'
         }
         onSelect={() => {
-          onReportChange(null, 'modify');
           if (customReportItems.mode === 'total') {
             setGraphType('BarGraph');
             if (['Net'].includes(customReportItems.balanceType)) {
@@ -88,7 +82,6 @@ export function ReportTopbar({
         title="Area Graph"
         selected={customReportItems.graphType === 'AreaGraph'}
         onSelect={() => {
-          onReportChange(null, 'modify');
           setGraphType('AreaGraph');
           setGroupBy('Month');
           onChangeViews('viewLegend', false);
@@ -103,7 +96,6 @@ export function ReportTopbar({
         title="Donut Graph"
         selected={customReportItems.graphType === 'DonutGraph'}
         onSelect={() => {
-          onReportChange(null, 'modify');
           setGraphType('DonutGraph');
           setTypeDisabled(['Net']);
           setBalanceType('Payment');
@@ -125,7 +117,6 @@ export function ReportTopbar({
       <GraphButton
         selected={viewLegend}
         onSelect={() => {
-          onReportChange(null, 'modify');
           onChangeViews('viewLegend');
         }}
         style={{ marginRight: 15 }}
@@ -168,22 +159,9 @@ export function ReportTopbar({
           flexShrink: 0,
         }}
       />
-      <FilterButton
-        compact
-        hover
-        onApply={e => {
-          onApplyFilter(e);
-          onReportChange(null, 'modify');
-        }}
-      />
+      <FilterButton onApply={onApplyFilter} compact hover />
       <View style={{ flex: 1 }} />
-      <SaveReport
-        customReportItems={customReportItems}
-        report={report}
-        savedStatus={savedStatus}
-        onReportChange={onReportChange}
-        onResetReports={onResetReports}
-      />
+      <SaveReportMenuButton />
     </View>
   );
 }
diff --git a/packages/desktop-client/src/components/reports/SaveReport.tsx b/packages/desktop-client/src/components/reports/SaveReport.tsx
index 4ec8942e5d6..3d1328e5742 100644
--- a/packages/desktop-client/src/components/reports/SaveReport.tsx
+++ b/packages/desktop-client/src/components/reports/SaveReport.tsx
@@ -1,136 +1,45 @@
 // @ts-strict-ignore
-import React, { createRef, useState } from 'react';
-
-import { v4 as uuidv4 } from 'uuid';
-
-import { send, sendCatch } from 'loot-core/src/platform/client/fetch';
-import { type CustomReportEntity } from 'loot-core/src/types/models';
+import React, { useState } from 'react';
 
 import { SvgExpandArrow } from '../../icons/v0';
 import { Button } from '../common/Button';
+import { Menu } from '../common/Menu';
+import { MenuTooltip } from '../common/MenuTooltip';
 import { Text } from '../common/Text';
 import { View } from '../common/View';
 
-import { SaveReportMenu } from './SaveReportMenu';
-import { SaveReportName } from './SaveReportName';
-
-type SaveReportProps<T extends CustomReportEntity = CustomReportEntity> = {
-  customReportItems: T;
-  report: CustomReportEntity;
-  savedStatus: string;
-  onReportChange: (savedReport: T, type: string) => void;
-  onResetReports: () => void;
-};
+function SaveReportMenu({ setMenuOpen }) {
+  return (
+    <MenuTooltip width={150} onClose={() => setMenuOpen(false)}>
+      <Menu
+        onMenuSelect={item => {
+          switch (item) {
+            case 'save':
+            case 'clear':
+              setMenuOpen(false);
+              break;
+            default:
+          }
+        }}
+        items={[
+          {
+            name: 'save',
+            text: 'Save new report',
+            disabled: true,
+          },
+          {
+            name: 'clear',
+            text: 'Clear all',
+            disabled: true,
+          },
+        ]}
+      />
+    </MenuTooltip>
+  );
+}
 
-export function SaveReport({
-  customReportItems,
-  report,
-  savedStatus,
-  onReportChange,
-  onResetReports,
-}: SaveReportProps) {
-  const [nameMenuOpen, setNameMenuOpen] = useState(false);
+export function SaveReportMenuButton() {
   const [menuOpen, setMenuOpen] = useState(false);
-  const [menuItem, setMenuItem] = useState(null);
-  const [err, setErr] = useState(null);
-  const [name, setName] = useState(report.name);
-  const inputRef = createRef<HTMLInputElement>();
-  const id = report.id;
-
-  const onAddUpdate = async () => {
-    let savedReport: CustomReportEntity;
-    let res;
-    //save existing states
-    savedReport = {
-      ...report,
-      ...customReportItems,
-    };
-
-    if (menuItem === 'save-report') {
-      //create new flow
-      /*
-      res = await sendCatch('report/create', {
-        ...savedReport,
-      });
-      */
-      savedReport = {
-        ...savedReport,
-        id: uuidv4(),
-        name,
-      };
-    }
-
-    if (menuItem === 'rename-report') {
-      //rename or update flow
-      //rename
-      savedReport = {
-        ...report,
-        name,
-      };
-    }
-
-    if (menuItem === 'update-report') {
-      savedReport = {
-        ...savedReport,
-        name: report.name,
-      };
-      //send update and rename to DB
-      /*
-      res = await sendCatch('report/update', {
-        ...savedReport,
-      });
-      */
-    }
-    if (res) {
-      setErr(res.error.message);
-      setNameMenuOpen(true);
-    } else {
-      setNameMenuOpen(false);
-      onReportChange(
-        savedReport,
-        menuItem === 'rename-report' ? 'rename' : 'add-update',
-      );
-    }
-  };
-
-  const onNameChange = cond => {
-    setName(cond);
-  };
-
-  const onMenuSelect = async item => {
-    setMenuItem(item);
-    switch (item) {
-      case 'rename-report':
-        setErr(null);
-        setMenuOpen(false);
-        setNameMenuOpen(true);
-        break;
-      case 'delete-report':
-        setMenuOpen(false);
-        //await send('report/delete', id);
-        onResetReports();
-        break;
-      case 'update-report':
-        setErr(null);
-        setMenuOpen(false);
-        onAddUpdate();
-        break;
-      case 'save-report':
-        setErr(null);
-        setMenuOpen(false);
-        setNameMenuOpen(true);
-        break;
-      case 'reload-report':
-        setMenuOpen(false);
-        onReportChange(null, 'reload');
-        break;
-      case 'reset-report':
-        setMenuOpen(false);
-        onResetReports();
-        break;
-      default:
-    }
-  };
 
   return (
     <View
@@ -154,28 +63,11 @@ export function SaveReport({
             flexShrink: 0,
           }}
         >
-          {!report.id ? 'Unsaved report' : report.name}&nbsp;
+          Unsaved Report&nbsp;
         </Text>
         <SvgExpandArrow width={8} height={8} style={{ marginRight: 5 }} />
       </Button>
-      {menuOpen && (
-        <SaveReportMenu
-          onClose={() => setMenuOpen(false)}
-          report={report}
-          onMenuSelect={onMenuSelect}
-          savedStatus={savedStatus}
-        />
-      )}
-      {nameMenuOpen && (
-        <SaveReportName
-          onClose={() => setNameMenuOpen(false)}
-          menuItem={menuItem}
-          onNameChange={onNameChange}
-          inputRef={inputRef}
-          onAddUpdate={onAddUpdate}
-          err={err}
-        />
-      )}
+      {menuOpen && <SaveReportMenu setMenuOpen={setMenuOpen} />}
     </View>
   );
 }
diff --git a/packages/desktop-client/src/components/reports/SaveReportMenu.tsx b/packages/desktop-client/src/components/reports/SaveReportMenu.tsx
deleted file mode 100644
index 01e311dd260..00000000000
--- a/packages/desktop-client/src/components/reports/SaveReportMenu.tsx
+++ /dev/null
@@ -1,76 +0,0 @@
-import React from 'react';
-
-import { type CustomReportEntity } from 'loot-core/src/types/models';
-
-import { Menu } from '../common/Menu';
-import { MenuTooltip } from '../common/MenuTooltip';
-
-export function SaveReportMenu({
-  report,
-  onClose,
-  onMenuSelect,
-  savedStatus,
-}: {
-  report: CustomReportEntity;
-  onClose: () => void;
-  onMenuSelect: (item: string) => void;
-  savedStatus: string;
-}) {
-  return (
-    <MenuTooltip width={150} onClose={onClose}>
-      <Menu
-        onMenuSelect={item => {
-          onMenuSelect(item);
-        }}
-        items={
-          report.id === undefined
-            ? [
-                {
-                  name: 'save-report',
-                  text: 'Save new report',
-                },
-                {
-                  name: 'reset-report',
-                  text: 'Reset to default',
-                },
-              ]
-            : savedStatus === 'saved'
-              ? [
-                  { name: 'rename-report', text: 'Rename' },
-                  { name: 'delete-report', text: 'Delete' },
-                  Menu.line,
-                  {
-                    name: 'save-report',
-                    text: 'Save new report',
-                  },
-                  {
-                    name: 'reset-report',
-                    text: 'Reset to default',
-                  },
-                ]
-              : [
-                  { name: 'rename-report', text: 'Rename' },
-                  {
-                    name: 'update-report',
-                    text: 'Update report',
-                  },
-                  {
-                    name: 'reload-report',
-                    text: 'Revert changes',
-                  },
-                  { name: 'delete-report', text: 'Delete' },
-                  Menu.line,
-                  {
-                    name: 'save-report',
-                    text: 'Save new report',
-                  },
-                  {
-                    name: 'reset-report',
-                    text: 'Reset to default',
-                  },
-                ]
-        }
-      />
-    </MenuTooltip>
-  );
-}
diff --git a/packages/desktop-client/src/components/reports/SaveReportName.tsx b/packages/desktop-client/src/components/reports/SaveReportName.tsx
deleted file mode 100644
index 16138e5b177..00000000000
--- a/packages/desktop-client/src/components/reports/SaveReportName.tsx
+++ /dev/null
@@ -1,72 +0,0 @@
-import React, { RefObject, useEffect } from 'react';
-
-import { theme } from '../../style';
-import { Button } from '../common/Button';
-import { Input } from '../common/Input';
-import { MenuTooltip } from '../common/MenuTooltip';
-import { Stack } from '../common/Stack';
-import { Text } from '../common/Text';
-import { FormField, FormLabel } from '../forms';
-
-type SaveReportNameProps = {
-  onClose: () => void;
-  menuItem: string;
-  onNameChange: (name: string) => void;
-  inputRef: RefObject<HTMLInputElement>;
-  onAddUpdate: () => void;
-  err: string;
-};
-
-export function SaveReportName({
-  onClose,
-  menuItem,
-  onNameChange,
-  inputRef,
-  onAddUpdate,
-  err,
-}: SaveReportNameProps) {
-  useEffect(() => {
-    if (inputRef.current) {
-      inputRef.current.focus();
-    }
-  }, []);
-
-  return (
-    <MenuTooltip width={325} onClose={onClose}>
-      {menuItem !== 'update-report' && (
-        <form>
-          <Stack
-            direction="row"
-            justify="flex-end"
-            align="center"
-            style={{ padding: 10 }}
-          >
-            <FormField style={{ flex: 1 }}>
-              <FormLabel
-                title="Report Name"
-                htmlFor="name-field"
-                style={{ userSelect: 'none' }}
-              />
-              <Input inputRef={inputRef} onUpdate={e => onNameChange(e)} />
-            </FormField>
-            <Button
-              type="primary"
-              style={{ marginTop: 18 }}
-              onClick={e => {
-                e.preventDefault();
-                onAddUpdate();
-              }}
-            >
-              {menuItem === 'save-report' ? 'Add' : 'Update'}
-            </Button>
-          </Stack>
-        </form>
-      )}
-      {err && (
-        <Stack direction="row" align="center" style={{ padding: 10 }}>
-          <Text style={{ color: theme.errorText }}>{err}</Text>
-        </Stack>
-      )}
-    </MenuTooltip>
-  );
-}
diff --git a/packages/desktop-client/src/components/reports/reports/CustomReport.jsx b/packages/desktop-client/src/components/reports/reports/CustomReport.jsx
index 9df0416ce23..80e8a33f6a1 100644
--- a/packages/desktop-client/src/components/reports/reports/CustomReport.jsx
+++ b/packages/desktop-client/src/components/reports/reports/CustomReport.jsx
@@ -81,10 +81,6 @@ export function CustomReport() {
   const [dataCheck, setDataCheck] = useState(false);
   const dateRangeLine = ReportOptions.dateRange.length - 3;
 
-  const [report, setReport] = useState(loadReport);
-  const [savedStatus, setSavedStatus] = useState(
-    location.state ? (location.state.report ? 'saved' : 'new') : 'new',
-  );
   const months = monthUtils.rangeInclusive(startDate, endDate);
 
   useEffect(() => {
@@ -224,7 +220,6 @@ export function CustomReport() {
   const onChangeDates = (startDate, endDate) => {
     setStartDate(startDate);
     setEndDate(endDate);
-    setSavedStatus('changed');
   };
 
   const onChangeViews = (viewType, status) => {
@@ -239,85 +234,10 @@ export function CustomReport() {
     }
   };
 
-  const onResetReports = () => {
-    const selectAll = [];
-    categories.grouped.map(categoryGroup =>
-      categoryGroup.categories.map(category => selectAll.push(category)),
-    );
-
-    setStartDate(defaultReport.startDate);
-    setEndDate(defaultReport.endDate);
-    setIsDateStatic(defaultReport.isDateStatic);
-    setDateRange(defaultReport.dateRange);
-    setMode(defaultReport.mode);
-    setGroupBy(defaultReport.groupBy);
-    setBalanceType(defaultReport.balanceType);
-    setShowEmpty(defaultReport.showEmpty);
-    setShowOffBudget(defaultReport.showOffBudget);
-    setShowUncategorized(defaultReport.showUncategorized);
-    setSelectedCategories(selectAll);
-    setGraphType(defaultReport.graphType);
-    onApplyFilter(null);
-    onCondOpChange(defaultReport.conditionsOp);
-    setReport(defaultReport);
-    setSavedStatus('new');
-  };
-
   const onChangeAppliedFilter = (filter, changedElement) => {
-    onReportChange(null, 'modify');
+    //onReportChange(null, 'modify');
     return changedElement(filter);
   };
-
-  const onReportChange = (savedReport, type) => {
-    switch (type) {
-      case 'add-update':
-        setSavedStatus('saved');
-        setReport(savedReport);
-        break;
-      case 'rename':
-        if (report.name.substr(report.name.length - 10) === '(modified)') {
-          setReport({ ...report, name: savedReport.name + ' (modified)' });
-        } else {
-          setReport({ ...report, name: savedReport.name });
-        }
-        break;
-      case 'modify':
-        if (report.name) {
-          setSavedStatus('changed');
-          if (report.name.substr(report.name.length - 10) !== '(modified)') {
-            setReport({ ...report, name: report.name + ' (modified)' });
-          }
-        }
-        break;
-      case 'reload':
-        setSavedStatus('saved');
-        if (report.name.substr(report.name.length - 10) === '(modified)') {
-          setReport({
-            ...report,
-            name: report.name.substr(0, report.name.length - 11),
-          });
-        }
-
-        setStartDate(report.startDate);
-        setEndDate(report.endDate);
-        setIsDateStatic(report.isDateStatic);
-        setDateRange(report.dateRange);
-        setMode(report.mode);
-        setGroupBy(report.groupBy);
-        setBalanceType(report.balanceType);
-        setShowEmpty(report.showEmpty);
-        setShowOffBudget(report.showOffBudget);
-        setShowUncategorized(report.showUncategorized);
-        setSelectedCategories(report.selectedCategories);
-        setGraphType(report.graphType);
-        onApplyFilter(null);
-        report.conditions.forEach(condition => onApplyFilter(condition));
-        onCondOpChange(report.conditionsOp);
-        break;
-      default:
-    }
-  };
-
   return (
     <View style={{ ...styles.page, minWidth: 650, overflow: 'hidden' }}>
       <Header title="Custom Reports" />
@@ -349,7 +269,6 @@ export function CustomReport() {
           setSelectedCategories={setSelectedCategories}
           onChangeDates={onChangeDates}
           onChangeViews={onChangeViews}
-          onReportChange={onReportChange}
         />
         <View
           style={{
@@ -358,8 +277,6 @@ export function CustomReport() {
         >
           <ReportTopbar
             customReportItems={customReportItems}
-            report={report}
-            savedStatus={savedStatus}
             setGraphType={setGraphType}
             setTypeDisabled={setTypeDisabled}
             setBalanceType={setBalanceType}
@@ -369,8 +286,6 @@ export function CustomReport() {
             viewLabels={viewLabels}
             onApplyFilter={onApplyFilter}
             onChangeViews={onChangeViews}
-            onReportChange={onReportChange}
-            onResetReports={onResetReports}
           />
           {filters && filters.length > 0 && (
             <View
@@ -390,7 +305,7 @@ export function CustomReport() {
                 onCondOpChange={filter =>
                   onChangeAppliedFilter(filter, onCondOpChange)
                 }
-                onUpdateChange={onReportChange}
+                //onUpdateChange={onReportChange}
               />
             </View>
           )}
diff --git a/upcoming-release-notes/2257.md b/upcoming-release-notes/2257.md
deleted file mode 100644
index 9413515c7ea..00000000000
--- a/upcoming-release-notes/2257.md
+++ /dev/null
@@ -1,6 +0,0 @@
----
-category: Enhancements
-authors: [carkom]
----
-
-Expanding the menu for saving reports and adding hooks and logic.