From 3d8527def0fb7c97df4c0d7df4344d4b9cd76e21 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Thu, 14 Nov 2024 18:11:16 +0000
Subject: [PATCH] :sparkles: release tracking budget feature

Solves #2999
---
 .../src/components/settings/Experimental.tsx  | 19 -------------------
 .../src/components/settings/index.tsx         |  2 +-
 .../src/hooks/useFeatureFlag.ts               |  1 -
 packages/loot-core/src/types/prefs.d.ts       |  1 -
 upcoming-release-notes/3833.md                |  6 ++++++
 5 files changed, 7 insertions(+), 22 deletions(-)
 create mode 100644 upcoming-release-notes/3833.md

diff --git a/packages/desktop-client/src/components/settings/Experimental.tsx b/packages/desktop-client/src/components/settings/Experimental.tsx
index d60e50b844b..7589b3630f6 100644
--- a/packages/desktop-client/src/components/settings/Experimental.tsx
+++ b/packages/desktop-client/src/components/settings/Experimental.tsx
@@ -67,23 +67,6 @@ function FeatureToggle({
   );
 }
 
-function TrackingBudgetFeature() {
-  const { t } = useTranslation();
-  const [budgetType = 'rollover'] = useSyncedPref('budgetType');
-  const enabled = useFeatureFlag('reportBudget');
-  const blockToggleOff = budgetType === 'report' && enabled;
-  return (
-    <FeatureToggle
-      flag="reportBudget"
-      disableToggle={blockToggleOff}
-      error={t('Switch to a envelope budget before turning off this feature')}
-      feedbackLink="https://github.com/actualbudget/actual/issues/2999"
-    >
-      <Trans>Budget mode toggle</Trans>
-    </FeatureToggle>
-  );
-}
-
 export function ExperimentalFeatures() {
   const [expanded, setExpanded] = useState(false);
 
@@ -92,8 +75,6 @@ export function ExperimentalFeatures() {
       primaryAction={
         expanded ? (
           <View style={{ gap: '1em' }}>
-            <TrackingBudgetFeature />
-
             <FeatureToggle flag="goalTemplatesEnabled">
               <Trans>Goal templates</Trans>
             </FeatureToggle>
diff --git a/packages/desktop-client/src/components/settings/index.tsx b/packages/desktop-client/src/components/settings/index.tsx
index 28239f3360e..792bdaf71a9 100644
--- a/packages/desktop-client/src/components/settings/index.tsx
+++ b/packages/desktop-client/src/components/settings/index.tsx
@@ -177,7 +177,7 @@ export function Settings() {
         <ThemeSettings />
         <FormatSettings />
         <EncryptionSettings />
-        {useFeatureFlag('reportBudget') && <BudgetTypeSettings />}
+        <BudgetTypeSettings />
         {isElectron() && <Backups />}
         <ExportBudget />
         <AdvancedToggle>
diff --git a/packages/desktop-client/src/hooks/useFeatureFlag.ts b/packages/desktop-client/src/hooks/useFeatureFlag.ts
index 062a54cd6d8..e5702740257 100644
--- a/packages/desktop-client/src/hooks/useFeatureFlag.ts
+++ b/packages/desktop-client/src/hooks/useFeatureFlag.ts
@@ -3,7 +3,6 @@ import type { FeatureFlag } from 'loot-core/src/types/prefs';
 import { useSyncedPref } from './useSyncedPref';
 
 const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
-  reportBudget: false,
   goalTemplatesEnabled: false,
   dashboards: false,
   actionTemplating: false,
diff --git a/packages/loot-core/src/types/prefs.d.ts b/packages/loot-core/src/types/prefs.d.ts
index 0c6f7ea498d..ba1e5424920 100644
--- a/packages/loot-core/src/types/prefs.d.ts
+++ b/packages/loot-core/src/types/prefs.d.ts
@@ -1,6 +1,5 @@
 export type FeatureFlag =
   | 'dashboards'
-  | 'reportBudget'
   | 'goalTemplatesEnabled'
   | 'actionTemplating'
   | 'upcomingLengthAdjustment'
diff --git a/upcoming-release-notes/3833.md b/upcoming-release-notes/3833.md
new file mode 100644
index 00000000000..49ef283f9bb
--- /dev/null
+++ b/upcoming-release-notes/3833.md
@@ -0,0 +1,6 @@
+---
+category: Features
+authors: [MatissJanis]
+---
+
+Release tracking budget feature.