diff --git a/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png b/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png
index c71cd6e9ae9..bf4a7ada07d 100644
Binary files a/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png and b/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png b/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png
index b208341ad67..f78d7062d7c 100644
Binary files a/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png and b/packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png
index a7a17f6d1c4..4ac36791ac1 100644
Binary files a/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png and b/packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png b/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png
index ccfa191c10e..999ecf4a0da 100644
Binary files a/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png and b/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png b/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
index bb4ec510d81..803866aea07 100644
Binary files a/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png and b/packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png
index 9c8cd497cf4..9d4020aca1f 100644
Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-2-chromium-linux.png differ
diff --git a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png
index 114f554ada2..4aa4ae4c06d 100644
Binary files a/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png and b/packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-category-4-chromium-linux.png differ
diff --git a/packages/desktop-client/src/components/NotesButton.tsx b/packages/desktop-client/src/components/NotesButton.tsx
index fb2770d8400..366f7c2ea99 100644
--- a/packages/desktop-client/src/components/NotesButton.tsx
+++ b/packages/desktop-client/src/components/NotesButton.tsx
@@ -145,7 +145,7 @@ export default function NotesButton({
id,
width = 12,
height = 12,
- defaultColor = theme.pageBackgroundModalActive,
+ defaultColor = theme.buttonNormalText,
tooltipPosition,
style,
}: NotesButtonProps) {
diff --git a/packages/desktop-client/src/components/budget/SidebarCategory.tsx b/packages/desktop-client/src/components/budget/SidebarCategory.tsx
index cf0559b3347..622b9869b67 100644
--- a/packages/desktop-client/src/components/budget/SidebarCategory.tsx
+++ b/packages/desktop-client/src/components/budget/SidebarCategory.tsx
@@ -66,6 +66,7 @@ function SidebarCategory({
);
@@ -121,10 +123,15 @@ function SidebarCategory({
innerRef={innerRef}
style={{
width: 200,
- '& button': { display: 'none' },
+ overflow: 'hidden',
+ '& .hover-visible': {
+ display: 'none',
+ },
...(!dragging &&
!dragPreview && {
- '&:hover button': { display: 'flex', color: theme.tableTextHover },
+ '&:hover .hover-visible': {
+ display: 'flex',
+ },
}),
...(dragging && { color: theme.formInputTextPlaceholderSelected }),
// The zIndex here forces the the view on top of a row below
diff --git a/packages/desktop-client/src/components/budget/SidebarGroup.tsx b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
index ec839b62a15..a7a9a8ed120 100644
--- a/packages/desktop-client/src/components/budget/SidebarGroup.tsx
+++ b/packages/desktop-client/src/components/budget/SidebarGroup.tsx
@@ -95,6 +95,7 @@ function SidebarGroup({
-
+
>
)}
@@ -150,8 +155,15 @@ function SidebarGroup({
...style,
width: 200,
backgroundColor: theme.tableRowHeaderBackground,
- '& button': { display: 'none' },
- '&:hover button': { display: 'flex', color: theme.tableTextHover },
+ overflow: 'hidden',
+ '& .hover-visible': {
+ display: 'none',
+ },
+ ...(!dragPreview && {
+ '&:hover .hover-visible': {
+ display: 'flex',
+ },
+ }),
...(dragPreview && {
paddingLeft: 10,
zIndex: 10000,
diff --git a/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx b/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx
index 58e18d32a0a..078a78913a3 100644
--- a/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx
+++ b/packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx
@@ -126,7 +126,7 @@ export default function BudgetSummary({ month }: BudgetSummaryProps) {
width={15}
height={15}
tooltipPosition="bottom-right"
- defaultColor={theme.pageTextSubdued} // notes page color
+ defaultColor={theme.pageTextLight}
/>
diff --git a/packages/desktop-client/src/components/filters/FiltersMenu.js b/packages/desktop-client/src/components/filters/FiltersMenu.js
index 16034382cca..59803286944 100644
--- a/packages/desktop-client/src/components/filters/FiltersMenu.js
+++ b/packages/desktop-client/src/components/filters/FiltersMenu.js
@@ -429,8 +429,8 @@ export function FilterButton({ onApply, compact, hover }) {
style={{
lineHeight: 1.5,
padding: '6px 10px',
- backgroundColor: theme.menuAutoCompleteBackground,
- color: theme.menuAutoCompleteText,
+ backgroundColor: theme.menuBackground,
+ color: theme.menuItemText,
}}
>
Filters
diff --git a/packages/desktop-client/src/components/reports/ChooseGraph.tsx b/packages/desktop-client/src/components/reports/ChooseGraph.tsx
index 4dca723153a..ad71b87a1eb 100644
--- a/packages/desktop-client/src/components/reports/ChooseGraph.tsx
+++ b/packages/desktop-client/src/components/reports/ChooseGraph.tsx
@@ -2,6 +2,7 @@ import React, { useRef } from 'react';
import View from '../common/View';
+import { type DataEntity, type Month } from './entities';
import AreaGraph from './graphs/AreaGraph';
import BarGraph from './graphs/BarGraph';
import BarLineGraph from './graphs/BarLineGraph';
@@ -14,17 +15,28 @@ import ReportTableHeader from './ReportTableHeader';
import ReportTableList from './ReportTableList';
import ReportTableTotals from './ReportTableTotals';
+type ChooseGraphProps = {
+ data: DataEntity;
+ mode: string;
+ graphType: string;
+ balanceType: string;
+ groupBy: string;
+ showEmpty: boolean;
+ scrollWidth: number;
+ setScrollWidth: (value: number) => void;
+ months: Month[];
+};
export function ChooseGraph({
data,
mode,
graphType,
balanceType,
groupBy,
- empty,
+ showEmpty,
scrollWidth,
setScrollWidth,
months,
-}) {
+}: ChooseGraphProps) {
const saveScrollWidth = value => {
setScrollWidth(!value ? 0 : value);
};
@@ -53,13 +65,12 @@ export function ChooseGraph({
style={{ flexGrow: 1 }}
data={data}
groupBy={groupBy}
- empty={empty}
balanceTypeOp={ReportOptions.balanceTypeMap.get(balanceType)}
/>
);
}
if (graphType === 'BarLineGraph') {
- return ;
+ return ;
}
if (graphType === 'DonutGraph') {
return (
@@ -67,13 +78,12 @@ export function ChooseGraph({
style={{ flexGrow: 1 }}
data={data}
groupBy={groupBy}
- empty={empty}
balanceTypeOp={ReportOptions.balanceTypeMap.get(balanceType)}
/>
);
}
if (graphType === 'LineGraph') {
- return ;
+ return ;
}
if (graphType === 'StackedBarGraph') {
return ;
@@ -94,7 +104,7 @@ export function ChooseGraph({
>
{title}
diff --git a/packages/desktop-client/src/components/reports/ReportOptions.tsx b/packages/desktop-client/src/components/reports/ReportOptions.tsx
index 69f0ef1626c..2642e634354 100644
--- a/packages/desktop-client/src/components/reports/ReportOptions.tsx
+++ b/packages/desktop-client/src/components/reports/ReportOptions.tsx
@@ -6,8 +6,8 @@ import {
} from 'loot-core/src/types/models';
const balanceTypeOptions = [
- { description: 'Expense', format: 'totalDebts' },
- { description: 'Income', format: 'totalAssets' },
+ { description: 'Payment', format: 'totalDebts' },
+ { description: 'Deposit', format: 'totalAssets' },
{ description: 'Net', format: 'totalTotals' },
];
@@ -21,10 +21,11 @@ const groupByOptions = [
];
const dateRangeOptions = [
- { description: '1 month', name: 1 },
- { description: '3 months', name: 2 },
- { description: '6 months', name: 5 },
- { description: '1 year', name: 11 },
+ { description: 'This month', name: 0 },
+ { description: 'Last month', name: 1 },
+ { description: 'Last 3 months', name: 2 },
+ { description: 'Last 6 months', name: 5 },
+ { description: 'Last 12 months', name: 11 },
{ description: 'Year to date', name: 'yearToDate' },
{ description: 'Last year', name: 'lastYear' },
{ description: 'All time', name: 'allMonths' },
@@ -108,7 +109,7 @@ type UncategorizedGroupEntity = CategoryGroupEntity & {
categories?: UncategorizedEntity[];
};
-const uncategouncatGrouprizedGroup: UncategorizedGroupEntity = {
+const uncategorizedGroup: UncategorizedGroupEntity = {
name: 'Uncategorized & Off Budget',
id: null,
hidden: false,
@@ -122,7 +123,7 @@ export const categoryLists = (
) => {
const categoryList = showUncategorized
? [
- ...categories.list,
+ ...categories.list.filter(f => showOffBudgetHidden || !f.hidden),
uncategorizedCategory,
transferCategory,
offBudgetCategory,
@@ -131,7 +132,7 @@ export const categoryLists = (
const categoryGroup = showUncategorized
? [
...categories.grouped.filter(f => showOffBudgetHidden || !f.hidden),
- uncategouncatGrouprizedGroup,
+ uncategorizedGroup,
]
: categories.grouped;
return [categoryList, categoryGroup] as const;
diff --git a/packages/desktop-client/src/components/reports/ReportSidebar.js b/packages/desktop-client/src/components/reports/ReportSidebar.js
index 5f22d0a13c7..c95c79ad595 100644
--- a/packages/desktop-client/src/components/reports/ReportSidebar.js
+++ b/packages/desktop-client/src/components/reports/ReportSidebar.js
@@ -46,8 +46,8 @@ function ModeButton({ selected, children, style, onSelect }) {
}
export function ReportSidebar({
- start,
- end,
+ startDate,
+ endDate,
onChangeDates,
dateRange,
setDateRange,
@@ -64,12 +64,12 @@ export function ReportSidebar({
setBalanceType,
mode,
setMode,
- empty,
- setEmpty,
- hidden,
- setHidden,
- uncat,
- setUncat,
+ showEmpty,
+ setShowEmpty,
+ showOffBudgetHidden,
+ setShowOffBudgetHidden,
+ showUncategorized,
+ setShowUncategorized,
categories,
selectedCategories,
setSelectedCategories,
@@ -114,7 +114,7 @@ export function ReportSidebar({
} else {
setTypeDisabled(['Net']);
if (['Net'].includes(balanceType)) {
- setBalanceType('Expense');
+ setBalanceType('Payment');
}
}
if (graphType === 'BarGraph') {
@@ -144,7 +144,7 @@ export function ReportSidebar({
}
}
if (['Net'].includes(balanceType) && graphType !== 'TableGraph') {
- setBalanceType('Expense');
+ setBalanceType('Payment');
}
};
@@ -274,9 +274,9 @@ export function ReportSidebar({
setEmpty(!empty)}
+ checked={showEmpty}
+ value={showEmpty}
+ onChange={() => setShowEmpty(!showEmpty)}
/>
@@ -406,9 +406,9 @@ export function ReportSidebar({