From 69b6106b5118567f737e83e5f2321ef7915267ad Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:30:50 +0100 Subject: [PATCH 1/6] Add support for "Hanseatic Bank" (access_valid_for_days max 89) --- src/app-gocardless/bank-factory.js | 2 ++ src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js | 11 +++++++++++ 2 files changed, 13 insertions(+) create mode 100644 src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js index c368b94fe..6588e031b 100644 --- a/src/app-gocardless/bank-factory.js +++ b/src/app-gocardless/bank-factory.js @@ -28,6 +28,7 @@ import SpkMarburgBiedenkopfHeladef1mar from './banks/spk-marburg-biedenkopf-hela import SpkWormsAlzeyRiedMalade51wor from './banks/spk-worms-alzey-ried-malade51wor.js'; import SwedbankHabaLV22 from './banks/swedbank-habalv22.js'; import VirginNrnbgb22 from './banks/virgin_nrnbgb22.js'; +import HanseaticBank from './banks/HANSEATIC_HSTBDEHH.js'; export const banks = [ AbancaCaglesmm, @@ -59,6 +60,7 @@ export const banks = [ SpkWormsAlzeyRiedMalade51wor, SwedbankHabaLV22, VirginNrnbgb22, + HanseaticBank, ]; export default (institutionId) => diff --git a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js new file mode 100644 index 000000000..d948f9d28 --- /dev/null +++ b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js @@ -0,0 +1,11 @@ +import Fallback from './integration-bank.js'; + +/** @type {import('./bank.interface.js').IBank} */ +export default { + ...Fallback, + + institutionIds: ['HANSEATIC_HSTBDEHH'], + + accessValidForDays: 89, + +}; \ No newline at end of file From 4de840a077f2a4f0f957e921e9983cbba9d27cf1 Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:35:22 +0100 Subject: [PATCH 2/6] add PR changelog file --- upcoming-release-notes/514.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 upcoming-release-notes/514.md diff --git a/upcoming-release-notes/514.md b/upcoming-release-notes/514.md new file mode 100644 index 000000000..67042ec23 --- /dev/null +++ b/upcoming-release-notes/514.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: Froghut +--- + +Fix gocardless bank "Hanseatic Bank" \ No newline at end of file From b57b35fc89b36e8bf79a56dbf2499c3798215a3f Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:38:08 +0100 Subject: [PATCH 3/6] fix line endings + author format --- .../banks/HANSEATIC_HSTBDEHH.js | 20 +++++++++---------- upcoming-release-notes/514.md | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js index d948f9d28..3fb8011b5 100644 --- a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js +++ b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js @@ -1,11 +1,11 @@ -import Fallback from './integration-bank.js'; - -/** @type {import('./bank.interface.js').IBank} */ -export default { - ...Fallback, - - institutionIds: ['HANSEATIC_HSTBDEHH'], - - accessValidForDays: 89, - +import Fallback from './integration-bank.js'; + +/** @type {import('./bank.interface.js').IBank} */ +export default { + ...Fallback, + + institutionIds: ['HANSEATIC_HSTBDEHH'], + + accessValidForDays: 89, + }; \ No newline at end of file diff --git a/upcoming-release-notes/514.md b/upcoming-release-notes/514.md index 67042ec23..6d47d90ae 100644 --- a/upcoming-release-notes/514.md +++ b/upcoming-release-notes/514.md @@ -1,6 +1,6 @@ --- category: Bugfix -authors: Froghut +authors: [Froghut] --- Fix gocardless bank "Hanseatic Bank" \ No newline at end of file From 9d92067fbf4ec0a3da10228ef167d5412a82e5e9 Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:39:37 +0100 Subject: [PATCH 4/6] make linter happy --- src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js index 3fb8011b5..e8bcb22b9 100644 --- a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js +++ b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js @@ -8,4 +8,4 @@ export default { accessValidForDays: 89, -}; \ No newline at end of file +}; From 3ef475cc8b9ece48ecf8598d214cdd6d9627d4d3 Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:41:16 +0100 Subject: [PATCH 5/6] make linter happy --- src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js index e8bcb22b9..143f92bf4 100644 --- a/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js +++ b/src/app-gocardless/banks/HANSEATIC_HSTBDEHH.js @@ -7,5 +7,4 @@ export default { institutionIds: ['HANSEATIC_HSTBDEHH'], accessValidForDays: 89, - }; From 6f028a93fcc034bffbe9787cd213755ae3f804fa Mon Sep 17 00:00:00 2001 From: Froghut Date: Tue, 3 Dec 2024 18:51:03 +0100 Subject: [PATCH 6/6] use alphabetical order for import and banks list --- src/app-gocardless/bank-factory.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app-gocardless/bank-factory.js b/src/app-gocardless/bank-factory.js index 6588e031b..aaa4f9304 100644 --- a/src/app-gocardless/bank-factory.js +++ b/src/app-gocardless/bank-factory.js @@ -9,6 +9,7 @@ import CBCcregbebb from './banks/cbc_cregbebb.js'; import DanskeBankDabNO22 from './banks/danskebank-dabno22.js'; import EasybankBawaatww from './banks/easybank-bawaatww.js'; import Fortuneo from './banks/FORTUNEO_FTNOFRP1XXX.js'; +import HanseaticBank from './banks/HANSEATIC_HSTBDEHH.js'; import IngIngbrobu from './banks/ing-ingbrobu.js'; import IngIngddeff from './banks/ing-ingddeff.js'; import IngPlIngbplpw from './banks/ing-pl-ingbplpw.js'; @@ -28,7 +29,6 @@ import SpkMarburgBiedenkopfHeladef1mar from './banks/spk-marburg-biedenkopf-hela import SpkWormsAlzeyRiedMalade51wor from './banks/spk-worms-alzey-ried-malade51wor.js'; import SwedbankHabaLV22 from './banks/swedbank-habalv22.js'; import VirginNrnbgb22 from './banks/virgin_nrnbgb22.js'; -import HanseaticBank from './banks/HANSEATIC_HSTBDEHH.js'; export const banks = [ AbancaCaglesmm, @@ -42,6 +42,7 @@ export const banks = [ DanskeBankDabNO22, EasybankBawaatww, Fortuneo, + HanseaticBank, IngIngbrobu, IngIngddeff, IngPlIngbplpw, @@ -60,7 +61,6 @@ export const banks = [ SpkWormsAlzeyRiedMalade51wor, SwedbankHabaLV22, VirginNrnbgb22, - HanseaticBank, ]; export default (institutionId) =>