🐛 (gocardless) fix banksync - create singleton client #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
toebbel
approved these changes
Nov 15, 2023
| @@ -18,11 +18,22 @@ import { SecretName, secretsService } from '../../services/secrets-service.js'; | |||
|
|
|||
| const GoCardlessClient = nordigenNode.default; | |||
|
|
|||
| const getGocardlessClient = () => | |||
| new GoCardlessClient({ | |||
| const clients = new Map(); | |||
There was a problem hiding this comment.
Can different budgets have different Nordigen secrets? I guess the Map makes sense here 👍
There was a problem hiding this comment.
Different budgets can have different secrets, but also the same budget might change its keys. So in that case too we also want to generate a new client.
Comment on lines
+31
to
+33
| if (!clients.has(hash)) { | ||
| clients.set(hash, new GoCardlessClient(secrets)); | ||
| } |
trafico-bot
bot
added
✅ Approved
youngcw
approved these changes
Nov 16, 2023
trafico-bot
bot
added
✨ Merged
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#267 introduced a small regression: the client is re-created every time it is used. Obviously this causes some problems as the access tokens get reset very often..
Instead I am now using a singleton client that is mapped by the secrets. Meaning: when secrets change we will generate a new client.