Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethiopic colon ፥ does not map on Windows #31

Open
eelstork opened this issue Aug 28, 2020 · 3 comments
Open

Ethiopic colon ፥ does not map on Windows #31

eelstork opened this issue Aug 28, 2020 · 3 comments

Comments

@eelstork
Copy link
Contributor

eelstork commented Aug 28, 2020 •
edited
Loading

፥ is not picked up and appears untouched in cs output, breaking builds
Observed on Windows.
@eelstork eelstork changed the title ፥ may not map correctly Ethiopic colon ፥ may not map correctly Aug 28, 2020
@eelstork eelstork mentioned this issue Aug 28, 2020
Closed
@eelstork eelstork changed the title Ethiopic colon ፥ may not map correctly Ethiopic colon ፥ may not map correctly on Windows Aug 28, 2020
@eelstork
Copy link
Contributor Author

Added tests for this; tests pass on macOS, Linux. Fail on Windows

@eelstork
Copy link
Contributor Author

Referring upstream dotnet/runtime#41534

@eelstork eelstork changed the title Ethiopic colon ፥ may not map correctly on Windows Ethiopic colon ፥ does not map on Windows Aug 28, 2020
@eelstork
Copy link
Contributor Author

This disappeared in 1.5; reason is simply because the mapping rule was phased out, and it is the mapping rule that caused the issue.
Branch 1.4; would be nice to know what actually went wrong in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eelstork