From e317dab430bc30d48b749779e7455a17fb3cf49a Mon Sep 17 00:00:00 2001 From: Shubham Bansal <62992590+shubham-bansal96@users.noreply.github.com> Date: Thu, 21 Sep 2023 21:21:31 +0530 Subject: [PATCH] Set code studio default env variable values to be masked (#1586) * make default env value to be masked * resolved mutants * revert changes to verify mutation test * verifying few things for mutation test * final changes to set default env vaule to be masked --------- Co-authored-by: Adam Balsam --- src/Command/CodeStudio/CodeStudioCiCdVariables.php | 8 ++++---- tests/phpunit/src/CommandTestBase.php | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Command/CodeStudio/CodeStudioCiCdVariables.php b/src/Command/CodeStudio/CodeStudioCiCdVariables.php index 6f422f6d4..3a5b50bd6 100644 --- a/src/Command/CodeStudio/CodeStudioCiCdVariables.php +++ b/src/Command/CodeStudio/CodeStudioCiCdVariables.php @@ -20,28 +20,28 @@ public static function getDefaults(?string $cloudApplicationUuid = NULL, ?string return [ [ 'key' => 'ACQUIA_APPLICATION_UUID', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => $cloudApplicationUuid, 'variable_type' => 'env_var', ], [ 'key' => 'ACQUIA_CLOUD_API_TOKEN_KEY', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => $cloudKey, 'variable_type' => 'env_var', ], [ 'key' => 'ACQUIA_CLOUD_API_TOKEN_SECRET', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => $cloudSecret, 'variable_type' => 'env_var', ], [ 'key' => 'ACQUIA_GLAB_TOKEN_NAME', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => $projectAccessTokenName, 'variable_type' => 'env_var', diff --git a/tests/phpunit/src/CommandTestBase.php b/tests/phpunit/src/CommandTestBase.php index 3df30847e..ab573ba7e 100644 --- a/tests/phpunit/src/CommandTestBase.php +++ b/tests/phpunit/src/CommandTestBase.php @@ -621,7 +621,7 @@ protected function getMockGitLabVariables(): array { 0 => [ 'environment_scope' => '*', 'key' => 'ACQUIA_APPLICATION_UUID', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => '2b3f7cf0-6602-4590-948b-3b07b1b005ef', 'variable_type' => 'env_var', @@ -629,7 +629,7 @@ protected function getMockGitLabVariables(): array { 1 => [ 'environment_scope' => '*', 'key' => 'ACQUIA_CLOUD_API_TOKEN_KEY', - 'masked' => FALSE, + 'masked' => TRUE, 'protected' => FALSE, 'value' => '111aae74-e81a-4052-b4b9-a27a62e6b6a6', 'variable_type' => 'env_var',