Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have some interactive slideshows #415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VishwaAmarasinghe
Copy link
Contributor

@VishwaAmarasinghe VishwaAmarasinghe commented Apr 12, 2022

Purpose

The purpose of this PR is to fix #413

Goals

Our site has no slideshows. To add highlighted and updated slideshow/carousel images or videos on the home screen of the
school page

Approach

Get help from this https://demos.creative-tim.com/material-kit-pro-bs4/sections.html#headers
and make the code

Screenshots

image

Preview Link

https://pr-415-sack-site-acf.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Sorry, something went wrong.

@VishwaAmarasinghe
Copy link
Contributor Author

We have to decide the content ( text, images/videos ) of this slideshow . What can we add to this ? Tell your suggestions @Piumal1999 @jayasanka-sack @Hasthikagirihagama @sathsarabandaraj @akeel230 @anjula-sack

@Hasthikagirihagama
Copy link
Collaborator

We have to decide the content ( text, images/videos ) of this slideshow . What can we add to this ? Tell your suggestions @Piumal1999 @jayasanka-sack @Hasthikagirihagama @sathsarabandaraj @akeel230 @anjula-sack

You could add Photos which are posted in the school Facebook page

Eg:- 103RD Bigmatch Encounter images
College Day and etc.

@VishwaAmarasinghe

@YoshithaRathnayake
Copy link
Member

@VishwaAmarasinghe solve these conflicts

Copy link
Member

@Piumal1999 Piumal1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VishwaAmarasinghe Good job!

For the header titles, no need to put the event name of the photo. Let's keep the title as it was before.

image

Copy link
Member

@Piumal1999 Piumal1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @VishwaAmarasinghe . I have added some comments. Please add the requested changes and let us know.

index.html Outdated
Comment on lines 7 to 9



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unwanted spaces

index.html Outdated



<div id="carouselExampleIndicators" class="carousel slide" data-ride="carousel">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a meaningful Id. (Update all the occurences)

Suggested change
<div id="carouselExampleIndicators" class="carousel slide" data-ride="carousel">
<div id="carouseIndicators" class="carousel slide" data-ride="carousel">

index.html Outdated
<div class="col-md-12 ml-auto mr-auto">
<div class="title text-left">
<h1>St.Anthony's College</h1>
<p style="font-family: 'Roboto'; font-size: 20px; font-weight: 400;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this comment #388 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same change to line 41 and 58

@@ -64,10 +124,10 @@ <h4 class="card-title">Nam aliquam bibendum ullamcorper. Praesent tempor</h4>
<button type="button" class="btn btn-class btn-sm">SEE MORE</button>
</div>
</div>
End of News section -->
//News section -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these unwanted changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having some interactive slideshows
4 participants