-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have some interactive slideshows #415
base: master
Are you sure you want to change the base?
Conversation
We have to decide the content ( text, images/videos ) of this slideshow . What can we add to this ? Tell your suggestions @Piumal1999 @jayasanka-sack @Hasthikagirihagama @sathsarabandaraj @akeel230 @anjula-sack |
You could add Photos which are posted in the school Facebook page Eg:- 103RD Bigmatch Encounter images |
@VishwaAmarasinghe solve these conflicts |
9582d0f
to
ae6cb74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VishwaAmarasinghe Good job!
For the header titles, no need to put the event name of the photo. Let's keep the title as it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @VishwaAmarasinghe . I have added some comments. Please add the requested changes and let us know.
index.html
Outdated
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unwanted spaces
index.html
Outdated
|
||
|
||
|
||
<div id="carouselExampleIndicators" class="carousel slide" data-ride="carousel"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a meaningful Id. (Update all the occurences)
<div id="carouselExampleIndicators" class="carousel slide" data-ride="carousel"> | |
<div id="carouseIndicators" class="carousel slide" data-ride="carousel"> |
index.html
Outdated
<div class="col-md-12 ml-auto mr-auto"> | ||
<div class="title text-left"> | ||
<h1>St.Anthony's College</h1> | ||
<p style="font-family: 'Roboto'; font-size: 20px; font-weight: 400;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this comment #388 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the same change to line 41 and 58
@@ -64,10 +124,10 @@ <h4 class="card-title">Nam aliquam bibendum ullamcorper. Praesent tempor</h4> | |||
<button type="button" class="btn btn-class btn-sm">SEE MORE</button> | |||
</div> | |||
</div> | |||
End of News section --> | |||
//News section --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these unwanted changes
Purpose
The purpose of this PR is to fix #413
Goals
Our site has no slideshows. To add highlighted and updated slideshow/carousel images or videos on the home screen of the
school page
Approach
Get help from this https://demos.creative-tim.com/material-kit-pro-bs4/sections.html#headers
and make the code
Screenshots
Preview Link
https://pr-415-sack-site-acf.surge.sh/
Checklist
Related PRs
Test environment
Learning