Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use solution-placement="{right|bottom|none}" rather than format= attribute #21

Open
armandofox opened this issue Aug 11, 2023 · 0 comments · May be fixed by #37
Open

use solution-placement="{right|bottom|none}" rather than format= attribute #21

armandofox opened this issue Aug 11, 2023 · 0 comments · May be fixed by #37
Assignees
@nelson-lojo
Labels
good first issue Good for newcomers pl-element about the prairielearn element/ui

Comments

@armandofox
Copy link
Contributor

in the existing PL element pl-order-blocks, it uses solution-placement="right|bottom" to specify where the target tray goes. we should use this same syntax but also allowing solution-placement="none" to indicate when only a single tray should appear.
we should also leave the current format= so that legacy questions don't break - ie make format an alias for solution-placement that we can deprecate later.
@armandofox armandofox added the good first issue Good for newcomers label Aug 11, 2023
@nelson-lojo nelson-lojo self-assigned this May 31, 2024
@nelson-lojo nelson-lojo linked a pull request Jun 11, 2024 that will close this issue
21 use solution placement=right|bottom|none rather than format= attribute #37
Open
@nelson-lojo nelson-lojo linked a pull request Jun 11, 2024 that will close this issue
Open
@SybelBlue SybelBlue added the pl-element about the prairielearn element/ui label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelson-lojo nelson-lojo

Labels
good first issue Good for newcomers pl-element about the prairielearn element/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

21 use solution placement=right|bottom|none rather than format= attribute ace-lab/pl-faded-parsons
3 participants
@armandofox @SybelBlue @nelson-lojo