🦋 Changeset detected

Latest commit: d74c0d3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💻 Website Preview

The latest changes are available as preview in: https://33a4e63c.accounts-js.pages.dev

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (760a59b) 92.59% compared to head (3b08baf) 92.59%.
Report is 2 commits behind head on master.

❗ Current head 3b08baf differs from pull request most recent head d74c0d3. Consider uploading reports for the commit d74c0d3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         117      117           
  Lines        2527     2527           
  Branches      569      569           
=======================================
  Hits         2340     2340           
  Misses        173      173           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

@darkbasic I was getting this up-and-running, using the documentation, and trying to take the most naive approach as possible, by using a plain JavaScript server (using server.js). When I run node server.js I'm getting an error about reflect-metadata:

node:internal/process/esm_loader:97
    internalBinding('errors').triggerUncaughtException(
                              ^
reflect-metadata shim is required when using class decorators

I wanted to touch base really fast, before adding it to the list I'm keeping for my PR on Documentation changes.

Should we encourage the use of TypeScript with the experimental decorators flag? Or am I just not configuring something, correctly?

What I have done so far is run:

yarn add @accounts/[email protected] graphql-modules @accounts/[email protected] @accounts/[email protected] @accounts/[email protected] @accounts/[email protected] @accounts/[email protected]

Then pasted your example code from getting started into server.js and issued node server.js.

Okay, looks like your example needed:

import 'reflect-metadata';

At the top. I'll put that on my list.

Yes you need reflect-metadata. If something from the documentation doesn't work I suggest you to have a look at the examples folder because these get tested much more often.
Docs need to be updated to reflect some of the latest changes.

Yes you need reflect-metadata. If something from the documentation doesn't work I suggest you to have a look at the examples folder because these get tested much more often. Docs need to be updated to reflect some of the latest changes.

Yeah, my plan is to take the documentation for a test drive and see if there are any holes in it for folks getting up and running. I was able to get up-and-running in about 30-45 minutes after some troubleshooting. So I took note of those missing elements. Most folks are going to want as little friction as possible while on-boarding. So I am keeping a list of changes I want to make to the documentation.

Good to know about the examples folder! Thanks.

Maybe we should leave comments in the open issues about the new release. I saw a very serious bug with a failed OAuth attempt that returned the first record from the users database. That's a pretty serious bug, but may be a non-issue after the re-factor? It'd be good to have the issue authors go back through after the official release to see if they are still experiencing their problems. Thoughts?

Maybe we should leave comments in the open issues about the new release. I saw a very serious bug with a failed OAuth attempt that returned the first record from the users database. That's a pretty serious bug, but may be a non-issue after the re-factor?

Yes leave comments in the respective issues if you find anything that you can still reproduce.
I saw the OAuth one and I honestly didn't check it yet, but that's surely one that needs to be addressed before the stable release.