diff --git a/samples/negative/development/invalid_openservice2json b/samples/negative/development/invalid_openservice2.json similarity index 100% rename from samples/negative/development/invalid_openservice2json rename to samples/negative/development/invalid_openservice2.json diff --git a/samples/negative/development/invalid_openservice3.json b/samples/negative/development/invalid_openservice3.json new file mode 100644 index 0000000..9e76655 --- /dev/null +++ b/samples/negative/development/invalid_openservice3.json @@ -0,0 +1,36 @@ +{ + "Version": "development", + "ReporterInfo": { + "ReporterOrg": "ExampleOrg", + "ReporterOrgDomain": "example.com", + "ReporterOrgEmail": "reports@example.com", + "ReporterContactEmail": "contact@example.com", + "ReporterContactName": "Mr. Example", + "ReporterContactPhone": "+ 01 000 1234567" + }, + "Disclosure": true, + "Report": { + "ReportType": "OpenService", + "ReportClass": "Vulnerability", + "FirstSeen": "2020-03-15T15:17:10Z", + "Date": "2020-07-24T14:17:10Z", + "Service": { + "Version": 2 + }, + "SourceIp": "192.0.2.55", + "SourcePort": 54321, + "Protocol": "thisisnoprotocol", + "Samples": [ + { + "ContentType": "text/plain", + "Base64Encoded": false, + "Description": "Log line", + "Payload": "EXAMPLE Nmap done: 1 IP address (1 host up) scanned in 5.58 seconds EXAMPLE" + } + ], + "Custom": { + "whatever": "examplevalue", + "whatever2": "examplevalue2" + } + } +} diff --git a/schemas/development/xarf_shared.schema.json b/schemas/development/xarf_shared.schema.json index 5d7437b..a65891f 100644 --- a/schemas/development/xarf_shared.schema.json +++ b/schemas/development/xarf_shared.schema.json @@ -429,11 +429,14 @@ "description": "Describes a service running on the network", "properties": { "Name": { + "description": "The name of the service. E.g. redis", "type": "string" }, "Version": { + "description": "Version of the service. E.g. 1.2.0 or 5.4", "type": "string" } - } + }, + "required": ["Name"] } }