Support for multiple Kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, and Labels. #57

d1egoaz · 2021-08-20T20:47:01Z

Add support to have multiple and functional kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, Labels, last command,

Closes #54

Some notes:

Kubel mode is only set once when the buffer is created.
Now when kubel is called, it'll always create a new buffer with fresh variables for
context, namespace, and resource.
Stop killing existing buffer when changing objects, instead, a new function
kubel-refresh is now taking care of displaying/refreshing current configuration.
Show a message when the command is being executed, to easily tell if a command
is being executed.

- Kubel mode is only set once when the buffer is created. - Now when `kubel` is called, it'll always create a new buffer with fresh variables for - context, namespace, and resource. - Stop killing existing buffer when changing objects, instead, a new function - `kubel-refresh` is now taking care of displaying/refreshing current configuration. - Show a message when the command is being executed, to easily tell if a command is being executed.

When there are too many kubel buffers is hard to differentiate what buffer belongs to an specific cluster/namespace

I added pipe and colon to buffer name, pretty sure that will not work in Windows

It wasn't taking into account parent cluster,buffer from where it was created

d1egoaz · 2021-09-16T03:46:37Z

Hey @abrochard

I added some more commits to fix an issue regarding kubectl apply (it wasn't working as I wasn't passing the context/namespace).

d1egoaz · 2021-09-16T03:50:14Z

Please 👀 and test, as most of the time I work on a different version of this package (different caching, single kubel process and err buffer process, I also plan to send some PRs after this gets 👍 or 👎), I only use this branch to send upstream changes.

…bel-buffers

d1egoaz · 2021-10-14T23:18:39Z

I merged latest master on top of the branch.

abrochard · 2021-10-15T02:36:28Z

README.md

@@ -54,6 +55,11 @@ M-x kubel-set-resource
 ```
 This will let you select a resource and re-display the kubel buffer.

+You can also use `kubel-open` to open directly a kubel buffer with the given parameters, example:
+``` lisp
+(kubel-open "custom-context" "custom-namespace" "custom-resource"))


big fan of this

I'm using it every day, you get a lot of time back as you don't need to wait for getting the list of context, list of namespaces and get list of pods, you can go directly to where you're interested.

Yeah it's really sweet. I'm also gonna hook it up to magit post-commit or something so I can monitor my deployment once I push a release.

README.md

I don't use tramp, so not sure if this is needed

abrochard · 2021-11-17T19:38:59Z

Hi @d1egoaz ,
Thank you for your patience! I finally got around to testing this and I found a workflow-breaking bug. Here is how I repro:

start fresh (kill all kubel buffers)
call M-x kubel and drop into my default context/namespace
press C to switch context and jump into another context (or press n to switch to another namespace)
press g to refresh my view
my buffer jumps back to my default context/namespace

I feel that pressing g should refresh the buffer I'm currently viewing, not the previously opened one here.

d1egoaz · 2022-03-05T23:13:23Z

Hi @d1egoaz , Thank you for your patience! I finally got around to testing this and I found a workflow-breaking bug. Here is how I repro:

start fresh (kill all kubel buffers)

call M-x kubel and drop into my default context/namespace

press C to switch context and jump into another context (or press n to switch to another namespace)

press g to refresh my view

my buffer jumps back to my default context/namespace

I feel that pressing g should refresh the buffer I'm currently viewing, not the previously opened one here.

Thanks for the feedback.

Let me try to review this again, I'll stop working on my personal/work branch and just move to use this PR branch so I can be fully committed with this change.

I was able to confirm the bug, let me try to find the 🐛

d1egoaz · 2022-03-06T00:00:37Z

Huh, for some reason g is not calling kubel-refresh but kubel (using describe-key)l

If I run M-x kubel-refresh it works as expected.

going to check what did I do with the keybindings

d1egoaz · 2022-03-06T00:20:44Z

I'm not sure why evil-define-key don't like mapping g 🤷

That said, I'm using a different key for refreshing the kubel session, as I found that I needed g for movement.

It'd be great in a future PR to follow the evil collection guidelines regarding the keys that might be used

I just sent a PR with the fix, s/g/x

abrochard · 2022-03-11T20:58:51Z

Hmm I'm really not a fan of updating the binding. I don't use evil so maybe it makes sense there to update to match the guidelines, but for regular mode, I find it very disruptive to change from g to x

d1egoaz · 2022-03-11T21:38:51Z

Hmm I'm really not a fan of updating the binding. I don't use evil so maybe it makes sense there to update to match the guidelines, but for regular mode, I find it very disruptive to change from g to x

yeah, sorry about that, I don't use the normal mode, I'll make the change only for evil, I just pushed a new commit

d1egoaz · 2022-03-11T21:40:37Z

🤔 if you're not using evil, I wonder how did you hit the bug? unless it's breaking for some other reason. When you have some time please check the bindings on your side to see what' the values for kubel-mode-map

abrochard · 2022-04-07T20:55:47Z

Hey @d1egoaz , Sorry for the super late reply!

I did another test of this just now, and there's definitely something weird on my side when loading the code and I need to manually force refresh the mode map. After I do, the g seems to behave correctly.

However, even after doing that, I see some weird behavior when I switch context.

if I'm in a kubel buffer and I hit C and pick another context, the new context replaces the old one and I can't find the old context buffer anymore
if i'm not in a kubel buffer and invoke kubel-set-context, it doesn't create a kubel buffer and instead fills up whatever buffer i'm in with the kubel outpout

d1egoaz · 2022-08-16T21:13:05Z

Hey, I'm close this for now, I've been OOO and OOC (computer) for several months as I was on paternity leave. I'll try to replicate your issues on my side, I used this fork for months without issues, I'd like to test on a vanilla emacs without my configuration to see if that's the issue.

I'll try to return here in some months with a validated PR.

Thanks

* Multi buffers support (take #57 and rebase) * Add kubel--read-buffer, improve kubel-refresh and kubel command --------- Co-authored-by: Diego Alvarez <[email protected]> Co-authored-by: Adrien Brochard <[email protected]>

d1egoaz added 11 commits August 20, 2021 13:29

Make some variables local to the buffer

e9d4b18

swap order, first context, next namespace, finally resource

39692b7

fix unbalanced parentheses and readme

31388d8

Add kubel-open function

9c73735

remove duplicated ending *

d20cfac

Easy way to differentiate kubel manager buffers vs kubel resources

0a57c5c

add more info regarding the cluster/context to buffer name

bb2131e

When there are too many kubel buffers is hard to differentiate what buffer belongs to an specific cluster/namespace

sanitize file name, I think needed for windows

f445e05

I added pipe and colon to buffer name, pretty sure that will not work in Windows

when applying provide more context

171abd8

fix for applying resources

6966ab6

It wasn't taking into account parent cluster,buffer from where it was created

align strings so cluster info get's the same visual column

a6a7d4e

<img src="https://screenshot.click/16-00-e54eg-wgzaz.png" width="50%" />

abrochard mentioned this pull request Oct 12, 2021

Helm support #67

Open

d1egoaz added 2 commits October 14, 2021 16:09

Merge remote-tracking branch 'upstream/master' into diego/multiple-ku…

623fa4e

…bel-buffers

fix fmt

3384c6a

abrochard reviewed Oct 15, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

d1egoaz added 3 commits October 16, 2021 10:41

it looks important for tramp users

4f02443

I don't use tramp, so not sure if this is needed

s/manager/session

e4c8b6b

polish a bit docs for new workflow

3f0f5e2

abrochard mentioned this pull request Jan 11, 2022

[feature-request] option to have multiple kubel buffers (instances) #54

Open

Kyrremann mentioned this pull request Jan 12, 2022

Opening edit/describe/so on in the same buffer as kubel #72

Closed

Fix issue where kubel-evil-mode-map doesn't bind correctly g

f757bd3

only modifying the g kubel-refresh binding in evil

03166ab

d1egoaz closed this Aug 16, 2022

TxGVNN mentioned this pull request Aug 27, 2022

[discuss] How about sections? #96

Closed

TxGVNN mentioned this pull request Aug 30, 2023

feat: each pair of namespace-resource will be a buffer #112

Closed

TxGVNN pushed a commit to TxGVNN/kubel that referenced this pull request Sep 11, 2023

Multi buffers support (take abrochard#57 and rebase)

558c5f3

TxGVNN pushed a commit to TxGVNN/kubel that referenced this pull request Sep 11, 2023

Multi buffers support (take abrochard#57 and rebase)

adc27bc

TxGVNN mentioned this pull request Sep 11, 2023

Feature: multiple kubel buffers #114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for multiple Kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, and Labels. #57

Support for multiple Kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, and Labels. #57

d1egoaz commented Aug 20, 2021 •

edited

Loading

d1egoaz commented Sep 16, 2021

d1egoaz commented Sep 16, 2021

d1egoaz commented Oct 14, 2021

abrochard Oct 15, 2021

d1egoaz Oct 16, 2021

abrochard Oct 18, 2021

abrochard commented Nov 17, 2021 •

edited

Loading

d1egoaz commented Mar 5, 2022

d1egoaz commented Mar 6, 2022

d1egoaz commented Mar 6, 2022

abrochard commented Mar 11, 2022

d1egoaz commented Mar 11, 2022

d1egoaz commented Mar 11, 2022

abrochard commented Apr 7, 2022

d1egoaz commented Aug 16, 2022

Support for multiple Kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, and Labels. #57

Support for multiple Kubel buffers, each one using a different combination of Contex, Namespace, Resource, Filters, and Labels. #57

Conversation

d1egoaz commented Aug 20, 2021 • edited Loading

d1egoaz commented Sep 16, 2021

d1egoaz commented Sep 16, 2021

d1egoaz commented Oct 14, 2021

abrochard Oct 15, 2021

Choose a reason for hiding this comment

d1egoaz Oct 16, 2021

Choose a reason for hiding this comment

abrochard Oct 18, 2021

Choose a reason for hiding this comment

abrochard commented Nov 17, 2021 • edited Loading

d1egoaz commented Mar 5, 2022

d1egoaz commented Mar 6, 2022

d1egoaz commented Mar 6, 2022

abrochard commented Mar 11, 2022

d1egoaz commented Mar 11, 2022

d1egoaz commented Mar 11, 2022

abrochard commented Apr 7, 2022

d1egoaz commented Aug 16, 2022

d1egoaz commented Aug 20, 2021 •

edited

Loading

abrochard commented Nov 17, 2021 •

edited

Loading