Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404 when updating a device registration #73

Open
tcard opened this issue Oct 30, 2017 · 8 comments
Open

Handle 404 when updating a device registration #73

tcard opened this issue Oct 30, 2017 · 8 comments

Comments

@tcard
Copy link
Contributor

tcard commented Oct 30, 2017

When the push activation state machine updates the registration and it encounters a 404, that means the device got deregistered somehow, probably through the admin API. We still should call the activation callback with the error, but we also should reset all local device data and move to NotActivated.

Part of https://github.com/ably/wiki/issues/161.

┆Issue is synchronized with this Jira Task by Unito

@tcard tcard self-assigned this Oct 30, 2017
@tbedford
Copy link
Contributor

It's not clear if this is a doc issue or not. If a docs issue, please provide a link to the relevant docs. Thanks.

@kavalerov
Copy link

I think this is potentially related to the SDK feature spec.

@owenpearson do you know the context for this by any chance?

@owenpearson
Copy link
Member

owenpearson commented Mar 31, 2021

@kavalerov yeah it's definitely a feature spec improvement suggestion. All the context is there if you follow the link to the ideas issue (and the subsequent link to this conversation which seems to be where the idea originated from).

@kavalerov
Copy link

@tbedford at the moment feature spec changes also live in the docs repo, so I think this means we need to reopen this issue for now

@kavalerov
Copy link

Big question is how we manage this moving forward, we probably can separate the spec from the actual documentation, because they serve two very different audiences. Should we maybe move the spec into a separate repo?

Or, we just keep things as they are and just use correct labels

@kavalerov kavalerov reopened this Apr 2, 2021
@tcard
Copy link
Contributor Author

tcard commented Apr 6, 2021

because they serve two very different audiences

Just my two cents, but: I believe the spec is valuable documentation for end users too, not just for SDK developers. It states exactly what the library does in a terse and exhaustive way that complements the more verbose, and not as deep, main documentation.

@kavalerov
Copy link

This is a good point @tcard. It would be good to see if customers are using the spec for this - right now we definitely don't make it easy to find, actually wise versa, it is pretty hidden in the docs.

I think the kind of exhaustive description of how the library works can potentially be part of the docs, but I am a bit worried about content serving two different audiences at the same time, as it will impact the decisions we make and tradeoffs we need to agree with (to be clear - I am not saying it is not valuable for both, I am saying that it is a problem that both can potentially use it).

@QuintinWillison QuintinWillison transferred this issue from ably/docs Oct 3, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Oct 17, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants