Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"release operation in progress" should be predicated by room ID? #251

Open
lawrence-forooghian opened this issue Dec 3, 2024 · 2 comments · May be fixed by #255
Open

"release operation in progress" should be predicated by room ID? #251

lawrence-forooghian opened this issue Dec 3, 2024 · 2 comments · May be fixed by #255
Assignees
@AndyTWF
Labels
chat Related to the Chat SDK.

Comments

@lawrence-forooghian
Copy link
Collaborator

*** @(CHA-RC1f3)@ @[Testable]@ If no @CHA-RC1g@ release operation is in progress, a new room instance shall be created, added to the room map and returned as the future value.
*** @(CHA-RC1f4)@ @[Testable]@ If a @CHA-RC1g@ release operation is in progress, the entry shall be added to the room map, but the new room instance must not be created until the release operation has resolved. The future shall then subsequently resolve with the new room value.
*** @(CHA-RC1g2)@ @[Testable]@ If the room does not exist in the room map, and no release operation is in progress, this operation is no-op.

I’m assuming (and have implemented this assumption in Swift) that all of these should be "release operation is in progress for this room ID"?
@lawrence-forooghian lawrence-forooghian added the chat Related to the Chat SDK. label Dec 3, 2024
@sacOO7
Copy link
Collaborator

sacOO7 commented Dec 4, 2024

@lawrence-forooghian yes, your assumption is right, release operation in progress is only valid for the given argument roomId.

@AndyTWF AndyTWF linked a pull request Dec 4, 2024 that will close this issue
Open
@AndyTWF
Copy link
Contributor

AndyTWF commented Dec 4, 2024

Yes you're correct - I have clarified in #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyTWF AndyTWF

Labels
chat Related to the Chat SDK.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chat: clarify room lifecycle in progress assumption ably/specification
3 participants
@AndyTWF @sacOO7 @lawrence-forooghian