Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit default values for ClientOptions' useTokenAuth, queryTime and fallbackHostsUseDefault #101

Open
funkyboy opened this issue Feb 26, 2018 · 2 comments

Comments

@funkyboy
Copy link
Contributor

funkyboy commented Feb 26, 2018

https://docs.ably.io/client-lib-development-guide/features/#TO3j4

┆Issue is synchronized with this Jira Task by Unito

@mattheworiordan
Copy link
Member

@funkyboy this issue, issue ably/docs#389 and ably/docs#390 are all really the same issue, so I would prefer in future we keep very related problems in one issue as clearly all three can be dealt with in one PR / fix.

Additionally, the issue is not that ClientOptions should tell what the default value is, but that some ambiguity in the spec exists because admittedly ".. When true, token authentication will always be used by the client." implies that it's false by default, but not that is not explicit enough.

However, if you refer to the https://docs.ably.io/client-lib-development-guide/features/#idl which is part of the spec, you will see that this is explicit and default values are specified.

So please close all three issues and perhaps just do a single PR / issue to address the ambiguities in the spec definitions.

@funkyboy also you omitted tags for all of these issues, please remember to tag issues when you create them.

@funkyboy funkyboy changed the title ClientOptions should tell what's the default value for useTokenAuth More explicit default values for ClientOptions' useTokenAuth, queryTime and fallbackHostsUseDefault Feb 27, 2018
@QuintinWillison QuintinWillison transferred this issue from ably/docs Oct 19, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Oct 19, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants