Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication between auth_options and client_options #802

Closed
tomczoink opened this issue Jan 20, 2020 · 2 comments · Fixed by #804
Closed

Reduce duplication between auth_options and client_options #802

tomczoink opened this issue Jan 20, 2020 · 2 comments · Fixed by #804
Assignees
@tomczoink
Labels
api-reference Anything that appears below the API reference blue fold

Comments

@tomczoink
Copy link
Contributor

Currently both AuthOptions and ClientOptions have overlap in content. We should DRY this up.
@tomczoink tomczoink self-assigned this Jan 20, 2020
@mattheworiordan
Copy link
Member

We should DRY this up.

You mean by, for example, using partials? Or from an end-user perspective?

@tomczoink
Copy link
Contributor Author

Here I'm meaning partials, apologies for the confusion.

@tomczoink tomczoink mentioned this issue Jan 21, 2020
Merged
@tomczoink tomczoink added the api-reference Anything that appears below the API reference blue fold label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomczoink tomczoink

Labels
api-reference Anything that appears below the API reference blue fold
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Condensed Token methods from auth_options and client_options into a partial ably/docs
2 participants
@mattheworiordan @tomczoink