Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push activation documentation has confusing library instance example & lacks details on clientId #709

Open
mattheworiordan opened this issue Jul 17, 2019 · 0 comments
Open

Push activation documentation has confusing library instance example & lacks details on clientId #709

mattheworiordan opened this issue Jul 17, 2019 · 0 comments
Labels
api-reference Anything that appears below the API reference blue fold bug A broken link, image etc no-sync Do not sync ticket to JIRA

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Jul 17, 2019 •
edited by ably-sync-bot
Loading

This code example doesn't explain:

  • Where a getAblyRealtime() comes from, why are we not using the official Ably.Realtime constructor
  • How auth works in the context of an activate call
  • It is very unclearly how a clientId is assigned to a device on activation. @paddybyers is making some changes to how this works anyway, so we should update in due course with that change rolling out.

screenshot_2019-07-17_10-43-51_am

screenshot_2019-07-17_10-43-44_am

┆Issue is synchronized with this Jira Bug by Unito
@mattheworiordan mattheworiordan added bug A broken link, image etc api-reference Anything that appears below the API reference blue fold push labels Jul 17, 2019
@mattheworiordan mattheworiordan changed the title Push activation documentation has confusing library instance example Push activation documentation has confusing library instance example & lacks details on clientId Jul 17, 2019
@MarkWoulfeAbly MarkWoulfeAbly added the no-sync Do not sync ticket to JIRA label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-reference Anything that appears below the API reference blue fold bug A broken link, image etc no-sync Do not sync ticket to JIRA
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattheworiordan @MarkWoulfeAbly