From 4d607ef4a77c27292d2f8ff6703be066fb12d758 Mon Sep 17 00:00:00 2001 From: Dominik Piatek Date: Thu, 30 Nov 2023 16:05:22 +0000 Subject: [PATCH 1/2] Fix update versions action --- .github/workflows/update-versions.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update-versions.yml b/.github/workflows/update-versions.yml index 839dcc2cd..d9e346259 100644 --- a/.github/workflows/update-versions.yml +++ b/.github/workflows/update-versions.yml @@ -27,10 +27,10 @@ jobs: - uses: actions/setup-node@v2 with: node-version: 16.17.0 - env: - NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - run: npm install -g yarn - name: Update preview app + env: + NPM_TOKEN: ${{ secrets.NPM_TOKEN }} run: | git config --global user.email "github@action.code" git config --global user.name "Github Action" @@ -40,3 +40,8 @@ jobs: uses: peter-evans/create-pull-request@v4 with: branch: update-versions-to-${{ steps.latesttag.outputs.tag }} + title: Update @ably/ui version in repo to ${{ steps.latesttag.outputs.tag }} + body: "Update files that are not updated during the release process. + Sometimes published packages are not available immediately so we open this PR for convenience." + # This is doesn't work due to what seems a permission issue https://github.com/peter-evans/create-pull-request/issues/155 + # team-reviewers: "team-website" From bd46e89af37567bcae633ff0a4d85b721d6a5538 Mon Sep 17 00:00:00 2001 From: Dominik Piatek Date: Thu, 30 Nov 2023 16:37:03 +0000 Subject: [PATCH 2/2] Fail action if curl does not work --- scripts/update-dependents.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/update-dependents.sh b/scripts/update-dependents.sh index 7aff9a83d..9909b2927 100755 --- a/scripts/update-dependents.sh +++ b/scripts/update-dependents.sh @@ -20,6 +20,7 @@ if [ -z "$WEBSITE_RESULT" ]; then else echo "Failed to trigger workflow:" echo $WEBSITE_RESULT + exit 1 fi echo "" @@ -37,4 +38,5 @@ if [ -z "$VOLTAIRE_RESULT" ]; then else echo "Failed to trigger workflow:" echo $VOLTAIRE_RESULT + exit 1 fi