From 1b3faa27bbb63801222d1e2882b655716880e042 Mon Sep 17 00:00:00 2001 From: Lawrence Forooghian Date: Thu, 25 Apr 2024 09:47:15 -0300 Subject: [PATCH] Turn off continue-on-error in CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want the workflow run to fail if any of the jobs fails. The motivation for the current configuration is not clear to me, but I’m guessing the idea was that the failure of a single job shouldn’t cancel the others. Turning off fail-fast should do the same thing. (Copied from ably-js commit ddef9f7.) --- .github/workflows/check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c5924660a..e50d5edbe 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -7,9 +7,9 @@ on: jobs: check: runs-on: ubuntu-latest - continue-on-error: true strategy: matrix: + fail-fast: false ruby: [ '2.7', '3.0', '3.1' ] protocol: [ 'json', 'msgpack' ] type: [ 'unit', 'acceptance' ]