[WIP] Remove use of promisify #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1540/features
github-actions
bot
temporarily deployed
to
staging/pull/1540/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1540/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1540/features
github-actions
bot
temporarily deployed
to
staging/pull/1540/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1540/typedoc
The return type of `restMixin.history(...)` is `void`.
i think it doesn't need to be great, the callback version of these methods is going to be removed soon anyway. actually, maybe we'd be better off adding overload signatures for the stuff we’ll be left with after the removal TODO I think we can maybe undo the PaginatedResource change
TODO implement whenPromiseSettles TODO what have I done with PaginatedResult, seeems like I've done the wron gthing
and hence remove usage of promisify TODO handle TODOs TODO check tests TODO notice the stuff that we've had to force unwrap here, and undo later if possible
lawrence-forooghian
force-pushed
the
remove-use-of-promisify
branch
from
8efe49c to
cb4184d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1540/features
github-actions
bot
temporarily deployed
to
staging/pull/1540/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1540/typedoc
...if they don't simultaneously make use of the error and the headers etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.