Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and fix tests in RealtimeCryptoTest, RealtimeResumeTest and others #871

Open
qsdigor opened this issue Nov 29, 2022 · 5 comments
Open

Enable and fix tests in RealtimeCryptoTest, RealtimeResumeTest and others #871

qsdigor opened this issue Nov 29, 2022 · 5 comments
Labels
code-quality Affects the developer experience when working in our codebase. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.

Comments

@qsdigor
Copy link
Contributor

qsdigor commented Nov 29, 2022 •
edited by sync-by-unito bot
Loading

There are 44 tests that are still ignored in RealtimeCryptoTest RealtimeResumeTest and other classes. This is way too many and ignoring tests leaves parts of code untested.
As the first step, we should enable all ignored tests in this class.
If there are failing tests we need to fix them and add new ones if necessary.

┆Issue is synchronized with this Jira Task by Unito
@qsdigor qsdigor self-assigned this Nov 29, 2022
@qsdigor qsdigor added testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. code-quality Affects the developer experience when working in our codebase. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. labels Nov 29, 2022
@qsdigor qsdigor linked a pull request Nov 29, 2022 that will close this issue
Enable and fix ignored tests #867
Closed
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 29, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3108

@qsdigor
Copy link
Contributor Author

qsdigor commented Dec 2, 2022

Almost all tests are enabled and fixed.
The ones that are not passing are:

  • Tests in RestProxyTest, it looks like neither combination for setting manual ProxyOptions works.
  • Test auth_client_match_token_clientId_fail() in RealtimeAuthTest passes locally but occasionally fails in CI/CD, for some reason expected failure code is 40100 rather than 40101 which is expected.
  • Test realtime_presence_suspended_reenter() in RealtimePresenceTest is flaky and fails on the second protocol iteration.

@qsdigor
Copy link
Contributor Author

qsdigor commented Dec 2, 2022

A lot of tests were improved to decrease the flakiness of tests. This is something that cannot be resolved this way and needs full refactoring to do so.

@sacOO7 sacOO7 self-assigned this Mar 1, 2024
This was referenced Mar 1, 2024
Merged
Closed
@sacOO7
Copy link
Collaborator

sacOO7 commented Mar 6, 2024

Created a PR to fix this issue => #991

@sacOO7
Copy link
Collaborator

sacOO7 commented Mar 11, 2024

Program client initiated sync same as ably/ably-cocoa@93716bb for testing purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.
Milestone
No milestone
2 participants
@sacOO7 @qsdigor