Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate ATTACH sent #1018

Open
sacOO7 opened this issue Jul 11, 2024 · 1 comment
Open

Avoid duplicate ATTACH sent #1018

sacOO7 opened this issue Jul 11, 2024 · 1 comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@sacOO7
Copy link
Collaborator

sacOO7 commented Jul 11, 2024

  • Attach related changes were introduced as a part of protocol 2.
  • As per protocol 2, ATTACH msg should be sent for every channel in attaching, attached and suspended states once connected.
  • There are various mechanisms by which duplicate ATTACH can be sent
  1. ATTACH is added to the connection or global queue before being sent, check description on -> [ECO-4687][Protocol-2] Fix duplicate outgoing ATTACH msg ably-ruby#416
  2. ATTACH is sent periodically when channel is in SUSPENDED state as per https://sdk.ably.com/builds/ably/specification/main/features/#RTL13b.
  3. In case of ably-java we had observed duplicate ATTACHED being received in the response during re-connection. Need to check if this is the case and how can we avoid it.

┆Issue is synchronized with this Jira Task by Unito

@ttypic ttypic added the bug Something isn't working. It's clear that this does need to be fixed. label Aug 19, 2024
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Dec 10, 2024

Proposed fix at #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

2 participants