Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent codebase state around whether SUSPENDED channel state is implemented #568

Open
QuintinWillison opened this issue Dec 6, 2022 · 3 comments · May be fixed by #671
Open

Inconsistent codebase state around whether SUSPENDED channel state is implemented #568

QuintinWillison opened this issue Dec 6, 2022 · 3 comments · May be fixed by #671
Assignees
@sacOO7
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Dec 6, 2022 •
edited by sync-by-unito bot
Loading

Our readme states:

There is no channel suspended state; this means that the client will not automatically reattach to channels if a connection becomes suspended and then resumes, and presence members associated with the client will not be automatically re-entered.

A code search for "SUSPENDED" reveals a few TODO comments against channel state code.

Also, concept of "unimplemented test" was introduced at some point to the backlog. I'm going to close all of these issues as they add no value to the backlog (the work to be done is under this issue) however I am recording them here for reference:

In the absence of deeper analysis I'm going to mark this issue as a bug for now.

┆Issue is synchronized with this Jira Task by Unito
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Dec 6, 2022
This was referenced Dec 6, 2022
Closed
Closed
Closed
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 6, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3138

This was referenced Dec 6, 2022
Closed
Closed
Closed
@owenpearson owenpearson removed their assignment Mar 27, 2024
@sacOO7 sacOO7 self-assigned this Jul 1, 2024
@sacOO7
Copy link
Collaborator

sacOO7 commented Jul 1, 2024

Update transitioner_integration_test -> channelTransitioner that transitions channel to suspended from attaching

@sacOO7 sacOO7 mentioned this issue Jul 1, 2024
Open
@sacOO7 sacOO7 linked a pull request Sep 9, 2024 that will close this issue
Draft
@sacOO7
Copy link
Collaborator

sacOO7 commented Sep 16, 2024

Also need to fix #644 as a part of this issue.
Related issue ->#545, when channel goes to and fro in ATTACH and SUSPENDED cycles, configures timeout for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sacOO7 sacOO7

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ECO-4549] Channel suspended state ably/ably-go
3 participants
@QuintinWillison @sacOO7 @owenpearson