Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ConnectionInfo / ConnectionDetails #231

Open
withakay opened this issue Jun 13, 2018 · 1 comment
Open

Review ConnectionInfo / ConnectionDetails #231

withakay opened this issue Jun 13, 2018 · 1 comment

Comments

@withakay
Copy link
Contributor

withakay commented Jun 13, 2018

Other ably libs just use a ConnectionDetails class, the dotnet lib has a ConnectionInfo class that has values mapped from a ConnectionDetails class (which is in a file called ConnectionDetailsMessage.cs).

We should review the rationale behind this design and see if it can be reduced to one class, to better match the other libraries.

If the design does in fact need 2 classes then the file name should at least match the class name, per the style guide.

┆Issue is synchronized with this Jira Task by Unito

@funkyboy funkyboy added the enhancement New feature or improved functionality. label Jun 13, 2018
@paddybyers
Copy link
Member

I agree that as a general rule, the library types should have the same names as the corresponding IDL types in the spec. If that's not possible (either due to restrictions in the target language, or implementation constraints in the library), then there should still be an obvious and consistent mapping from IDL type names to library type names.

@ably-sync-bot ably-sync-bot removed the enhancement New feature or improved functionality. label Oct 7, 2020
@jamienewcomb jamienewcomb added the enhancement New feature or improved functionality. label Oct 7, 2020
@sync-by-unito sync-by-unito bot removed the enhancement New feature or improved functionality. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants