Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3770] Fix logging issue across multiple rest/realtime/push instances #1251

Closed
wants to merge 22 commits into from
Closed

[SDK-3770] Fix logging issue across multiple rest/realtime/push instances #1251

wants to merge 22 commits into from

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Aug 2, 2023 •
edited
Loading

@sacOO7 sacOO7 requested review from marto83 and owenpearson August 2, 2023 18:59
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 2, 2023 19:00 Inactive
@sacOO7 sacOO7 changed the title Fix logging issue across multiple realtime instances [SDK-3770] Fix logging issue across multiple realtime instances Aug 2, 2023
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Aug 2, 2023

Seems this PR is going to be a bit bigger, because at multiple passes original instance of logger is not being passed : (

@sacOO7 sacOO7 marked this pull request as draft August 2, 2023 19:39
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 17:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 17:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 17:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 18:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 18:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 20:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1251/features August 10, 2023 21:05 Inactive
@sacOO7 sacOO7 changed the title [SDK-3770] Fix logging issue across multiple realtime instances [SDK-3770] Fix logging issue across multiple rest/realtime/push instances Aug 13, 2023
@sacOO7 sacOO7 marked this pull request as ready for review August 13, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove reflection from IOC class LogHandler is shared between multiple AblyRealtime instances
2 participants
@sacOO7 @jamienewcomb