From 2e1fd01c2f392299cf60d0513bd1107a74885699 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Fri, 19 Apr 2024 13:33:45 +0530 Subject: [PATCH] Removed unnecessary test for fallbacks with default host --- .../Realtime/ConnectionAttemptsInfoSpecs.cs | 11 +---------- src/IO.Ably.Tests.Shared/Rest/RestSpecs.cs | 2 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/IO.Ably.Tests.Shared/Realtime/ConnectionAttemptsInfoSpecs.cs b/src/IO.Ably.Tests.Shared/Realtime/ConnectionAttemptsInfoSpecs.cs index 02f7d8e38..5d07db566 100644 --- a/src/IO.Ably.Tests.Shared/Realtime/ConnectionAttemptsInfoSpecs.cs +++ b/src/IO.Ably.Tests.Shared/Realtime/ConnectionAttemptsInfoSpecs.cs @@ -57,15 +57,6 @@ public void ShouldSuspend_WhenFirstAttemptEqualOrGreaterThanConnectionStateTtl_S state.ShouldSuspend(now.ValueFn).Should().BeTrue("When time is greater than"); // > } - [Fact] - public async Task CanAttemptFallback_ShouldBeFalseWithNonDefaultHost() - { - var client = GetRealtime(opts => opts.RealtimeHost = "test.test.com"); - - var result = await client.RestClient.CanFallback(null); - result.Should().BeFalse(); - } - [Theory] [InlineData(500)] [InlineData(501)] @@ -84,7 +75,7 @@ public async Task CanAttemptFallback_WithDefaultHostAndAppropriateError_ShouldBe public async Task CanAttemptFallback_WhenInternetCheckFails_ShouldBeFalse() { var client = GetRealtime(internetCheckOk: false); - var result = await client.RestClient.CanFallback(null); + var result = await client.RestClient.CanFallback(ErrorInfo.ReasonUnknown); result.Should().BeFalse(); } diff --git a/src/IO.Ably.Tests.Shared/Rest/RestSpecs.cs b/src/IO.Ably.Tests.Shared/Rest/RestSpecs.cs index 1805e7d46..fee022c30 100644 --- a/src/IO.Ably.Tests.Shared/Rest/RestSpecs.cs +++ b/src/IO.Ably.Tests.Shared/Rest/RestSpecs.cs @@ -607,7 +607,7 @@ public async Task ShouldUseCustomFallbackHostIfProvided() [Fact] [Trait("spec", "RSC15a")] [Trait("spec", "TO3k6")] - public async Task ShouldUseProvidedCustomFallbackHostWhenDefaultHostIsDifferent() + public async Task ShouldUseProvidedCustomFallbackHostIrrespectiveOfPrimaryHost() { _response.StatusCode = HttpStatusCode.BadGateway; var attemptedList = new List();