Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spaces identifier #221

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Update spaces identifier #221

merged 1 commit into from
Nov 3, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Nov 2, 2023

ruimffl
ruimffl approved these changes Nov 2, 2023
View reviewed changes
Copy link

@ruimffl ruimffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dpiatek
Copy link
Contributor Author

dpiatek commented Nov 3, 2023

thanks for the review @owenpearson - any chance you could merge it as well? :) (I don't have the right permissions)

@paddybyers paddybyers merged commit f46ed70 into main Nov 3, 2023
2 checks passed
@paddybyers paddybyers deleted the update-spaces-identifier branch November 3, 2023 09:10
@dpiatek
Copy link
Contributor Author

dpiatek commented Nov 3, 2023

thanks @paddybyers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@ruimffl ruimffl ruimffl approved these changes

@lmars lmars Awaiting requested review from lmars

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpiatek @ruimffl @owenpearson @paddybyers