From 6485829f9f6c592814cf6fdc852013d1267e7e8f Mon Sep 17 00:00:00 2001 From: Marat Al Date: Thu, 18 Jan 2024 20:14:40 +0100 Subject: [PATCH 1/2] Bump version to 1.2.24. --- README.md | 4 ++-- Scripts/jazzy.sh | 2 +- Source/ARTClientInformation.m | 2 +- Test/Tests/ARTDefaultTests.swift | 2 +- Test/Tests/ClientInformationTests.swift | 6 +++--- Test/Tests/RealtimeClientConnectionTests.swift | 2 +- Test/Tests/RestClientTests.swift | 2 +- Version.xcconfig | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 09606c809..a6fd12169 100644 --- a/README.md +++ b/README.md @@ -61,7 +61,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth - [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail. - To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`: ```swift - .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.23"), + .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.24"), ``` ### Installing through [CocoaPods](https://cocoapods.org/) @@ -101,7 +101,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram ### Manual installation -1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.23), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git` +1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.24), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git` 2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group. 3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project. diff --git a/Scripts/jazzy.sh b/Scripts/jazzy.sh index cae2537d1..0d721b4da 100755 --- a/Scripts/jazzy.sh +++ b/Scripts/jazzy.sh @@ -7,7 +7,7 @@ jazzy \ --objc \ --clean \ --author Ably \ - --module-version 1.2.23 \ + --module-version 1.2.24 \ --umbrella-header Source/include/Ably/Ably.h \ --framework-root Source \ --module Ably \ diff --git a/Source/ARTClientInformation.m b/Source/ARTClientInformation.m index d3f9d49a1..e52b8d83e 100644 --- a/Source/ARTClientInformation.m +++ b/Source/ARTClientInformation.m @@ -6,7 +6,7 @@ #import NSString *const ARTClientInformationAgentNotVersioned = @"ARTClientInformationAgentNotVersioned"; -NSString *const ARTClientInformation_libraryVersion = @"1.2.23"; +NSString *const ARTClientInformation_libraryVersion = @"1.2.24"; static NSString *const _libraryName = @"ably-cocoa"; // NSOperatingSystemVersion has NSInteger as version components for some reason, so mitigate it here. diff --git a/Test/Tests/ARTDefaultTests.swift b/Test/Tests/ARTDefaultTests.swift index 8f13c133e..b6ec36314 100644 --- a/Test/Tests/ARTDefaultTests.swift +++ b/Test/Tests/ARTDefaultTests.swift @@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase { func testVersions() { XCTAssertEqual(ARTDefault.apiVersion(), "1.2") - XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.23") + XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.24") } } diff --git a/Test/Tests/ClientInformationTests.swift b/Test/Tests/ClientInformationTests.swift index f4cc9dd5b..7bb528281 100644 --- a/Test/Tests/ClientInformationTests.swift +++ b/Test/Tests/ClientInformationTests.swift @@ -9,7 +9,7 @@ final class ClientInformationTests: XCTestCase { XCTAssertEqual(agents.keys.count, 2) - XCTAssertEqual(agents["ably-cocoa"], "1.2.23") + XCTAssertEqual(agents["ably-cocoa"], "1.2.24") #if os(iOS) XCTAssertTrue(agents.keys.contains("iOS")) @@ -27,7 +27,7 @@ final class ClientInformationTests: XCTestCase { // CR3, CR3b func testAgentIdentifierWithAdditionalAgents_withNilAdditionalAgents() { let expectedIdentifier = [ - "ably-cocoa/1.2.23", + "ably-cocoa/1.2.24", ARTDefault.platformAgent() ].sorted().joined(separator: " ") @@ -42,7 +42,7 @@ final class ClientInformationTests: XCTestCase { ] let expectedIdentifier = [ - "ably-cocoa/1.2.23", + "ably-cocoa/1.2.24", "demolib/0.0.1", "morelib", ARTDefault.platformAgent() diff --git a/Test/Tests/RealtimeClientConnectionTests.swift b/Test/Tests/RealtimeClientConnectionTests.swift index 84621aa72..27c09c92e 100644 --- a/Test/Tests/RealtimeClientConnectionTests.swift +++ b/Test/Tests/RealtimeClientConnectionTests.swift @@ -381,7 +381,7 @@ class RealtimeClientConnectionTests: XCTestCase { done() case .connected: if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query { - expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.23")) + expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.24")) } else { XCTFail("MockTransport isn't working") } diff --git a/Test/Tests/RestClientTests.swift b/Test/Tests/RestClientTests.swift index 14d0b151b..72a1753fa 100644 --- a/Test/Tests/RestClientTests.swift +++ b/Test/Tests/RestClientTests.swift @@ -1736,7 +1736,7 @@ class RestClientTests: XCTestCase { let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"] let ablyAgent = ARTClientInformation.agentIdentifier(withAdditionalAgents: options.agents) XCTAssertEqual(headerAgent, ablyAgent) - XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.23")) + XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.24")) done() } } diff --git a/Version.xcconfig b/Version.xcconfig index a18bb0470..992742305 100644 --- a/Version.xcconfig +++ b/Version.xcconfig @@ -1 +1 @@ -CURRENT_PROJECT_VERSION = 1.2.23 +CURRENT_PROJECT_VERSION = 1.2.24 From 13767b0cf68733cfa036188e0d8edca24b8e3f98 Mon Sep 17 00:00:00 2001 From: Marat Al Date: Thu, 18 Jan 2024 21:17:00 +0100 Subject: [PATCH 2/2] Update change log. --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 803c98b62..c345bda3c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,14 @@ # Change Log +## [1.2.24](https://github.com/ably/ably-cocoa/tree/1.2.24) + +[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.23...1.2.24) + +**Fixed issues:** + +- Push device deregistration does not clear device details. [\#1177](https://github.com/ably/ably-cocoa/issues/1177) +- Unrecognized selector sent to instance. [\#1837](https://github.com/ably/ably-cocoa/issues/1837) + ## [1.2.23](https://github.com/ably/ably-cocoa/tree/1.2.23) [Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.22...1.2.23)