Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create channels / features for the features that the user has requested #105

Closed
lawrence-forooghian opened this issue Nov 11, 2024 · 0 comments · Fixed by #138
Closed
Assignees
Labels
enhancement New feature or improved functionality.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Nov 11, 2024

We’re meant to only create these if the user has requested the feature (i.e. by passing an options object for that feature). Else I guess users might end up paying for features they didn’t request. Not sure if there's a spec point for this, but it's something we need to implement.

Whilst we're in this area, think about @umair-ably’s comment in #103 (comment) about avoiding force unwrap when passing channel to feature.

┆Issue is synchronized with this Jira Story by Unito

@lawrence-forooghian lawrence-forooghian added the enhancement New feature or improved functionality. label Nov 11, 2024
@lawrence-forooghian lawrence-forooghian self-assigned this Nov 20, 2024
lawrence-forooghian added a commit that referenced this issue Nov 20, 2024
TODO spec point

TODO test that options are only specified if feature needs them (we can
put them into an earlier test which we then split up)

TODO test that contributors are only passed if feature is there (we can
put this into an earlier test which we then split up)

Resolves #105.
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
This tests the current behaviour, upon which we will improve in #105.
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
TODO spec point

TODO test that options are only specified if feature needs them (i.e.
split up test from previous commit)

TODO test that contributors are only passed if feature is there (i.e.
split up test from previous commit)

Resolves #105.
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
The implemented spec points have not yet been merged into `main`; they
come from [1] at b0912a5.

Resolves #105.

[1] ably/specification#237
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
The implemented spec points have not yet been merged into `main`; they
come from [1] at b0912a5.

Resolves #105.

[1] ably/specification#237
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
The implemented spec points have not yet been merged into `main`; they
come from [1] at 92de25b.

Resolves #105.

[1] ably/specification#237
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
This tests the current behaviour, upon which we will improve in #105.
lawrence-forooghian added a commit that referenced this issue Nov 21, 2024
This tests the current behaviour, upon which we will improve in #105.
lawrence-forooghian added a commit that referenced this issue Nov 25, 2024
This tests the current behaviour, upon which we will improve in #105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
1 participant