Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker Queue: Legacy #569

Closed
AndyTWF opened this issue Feb 20, 2023 · 3 comments · Fixed by #573
Closed

Worker Queue: Legacy #569

AndyTWF opened this issue Feb 20, 2023 · 3 comments · Fixed by #573
Assignees
Milestone

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Feb 20, 2023

As part of the worker queue migration, we could adapt the current publishers do async work method to push that work onto the worker queue (a generic worker - takes a simple callback and runs it). That way we can confine all the async work to the queue, as we refactor out the workers.

Depends on the following work:

@AndyTWF AndyTWF added this to the 1.0.0 milestone Feb 20, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Feb 20, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3382

@AndyTWF AndyTWF changed the title Worker Queue: Legacy Publisher Worker Queue: Legacy Feb 23, 2023
@AndyTWF AndyTWF changed the title Publisher Worker Queue: Legacy Worker Queue: Legacy Feb 23, 2023
@lawrence-forooghian
Copy link
Collaborator

@AndyTWF To check I’ve understood – the idea here is to instantiate a worker queue inside DefaultPublisher and DefaultSubscriber, and to replace their performOnWorking{Thread, Queue} methods with a method that enqueues this generic function-calling worker, right?

@lawrence-forooghian
Copy link
Collaborator

Also, it says that it depends on #590, but that seems to be publisher specific whereas I assumed this one was about publisher and subscriber. I also don't think that we need the full properties types (i.e. #570) to be implemented in order to do this one – we just need empty placeholder properties types for publisher and subscriber, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants