Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a client for sdk-test-proxy #537

Closed
lawrence-forooghian opened this issue Feb 14, 2023 · 1 comment · Fixed by #577
Closed

Implement a client for sdk-test-proxy #537

lawrence-forooghian opened this issue Feb 14, 2023 · 1 comment · Fixed by #577
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Feb 14, 2023 •
edited by sync-by-unito bot
Loading

This is needed for #535.

Implement a client that exposes the same interface to https://github.com/ably/sdk-test-proxy as that which we implement in ably/ably-asset-tracking-android#1003.
@sync-by-unito
Copy link

sync-by-unito bot commented Feb 14, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3346

This was referenced Feb 14, 2023
Open
Open
lawrence-forooghian added a commit that referenced this issue Feb 21, 2023
@lawrence-forooghian
WIP client for proxy
d5415bc 
TODO instructions on how to run

Resolves #537.
lawrence-forooghian added a commit that referenced this issue Feb 21, 2023
@lawrence-forooghian
WIP client for proxy
e77b02f 
TODO instructions on how to run

Resolves #537.
lawrence-forooghian added a commit that referenced this issue Feb 21, 2023
@lawrence-forooghian
Add a client for sdk-test-proxy
50641ba 
The code and comments are more or less copied from the Android codebase
at commit 7f05c3c. I’ve changed the class name from FaultProxyClient to
SDKTestProxyClient, as it’s more in line with the name of the proxy
repo.

We also add a test to check that the local proxy is running and that the
client is working. This means we now need to run the proxy in CI, so we
do that.

Resolves #537.
@lawrence-forooghian lawrence-forooghian mentioned this issue Feb 21, 2023
Merged
lawrence-forooghian added a commit that referenced this issue Feb 21, 2023
@lawrence-forooghian
Add a client for sdk-test-proxy
d3ae91f 
The code and comments are more or less copied from the Android codebase
at commit 7f05c3c. I’ve changed the class name from FaultProxyClient to
SDKTestProxyClient, as it’s more in line with the name of the proxy
repo.

We also add a test to check that the local proxy is running and that the
client is working. This means we now need to run the proxy in CI, so we
do that.

Resolves #537.
lawrence-forooghian added a commit that referenced this issue Feb 21, 2023
@lawrence-forooghian
Add a client for sdk-test-proxy
eaab278 
The code and comments are more or less copied from the Android codebase
at commit 7f05c3c. I’ve changed the class name from FaultProxyClient to
SDKTestProxyClient, as it’s more in line with the name of the proxy
repo.

We also add a test to check that the local proxy is running and that the
client is working. This means we now need to run the proxy in CI, so we
do that.

Resolves #537.
lawrence-forooghian added a commit that referenced this issue Feb 22, 2023
@lawrence-forooghian
Add a client for sdk-test-proxy
42c9643 
The code and comments are more or less copied from the Android codebase
at commit 7f05c3c. I’ve changed the class name from FaultProxyClient to
SDKTestProxyClient, as it’s more in line with the name of the proxy
repo.

We also add a test to check that the local proxy is running and that the
client is working. This means we now need to run the proxy in CI, so we
do that.

Resolves #537.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a client for sdk-test-proxy ably/ably-asset-tracking-swift
1 participant
@lawrence-forooghian