Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity of state transition assertions in NetworkConnectivityTests #901

Closed
QuintinWillison opened this issue Jan 13, 2023 · 1 comment · Fixed by #916
Closed

Reduce complexity of state transition assertions in NetworkConnectivityTests #901

QuintinWillison opened this issue Jan 13, 2023 · 1 comment · Fixed by #916
Assignees
@davyskiba
Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.

Comments

@QuintinWillison
Copy link
Contributor

Noticed by @davyskiba and described in this review comment.
@QuintinWillison QuintinWillison added code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. labels Jan 13, 2023
@QuintinWillison QuintinWillison mentioned this issue Jan 13, 2023
Merged
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 13, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3240

@davyskiba davyskiba self-assigned this Jan 13, 2023
@davyskiba davyskiba mentioned this issue Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davyskiba davyskiba

Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

901 simplify transition assertions ably/ably-asset-tracking-android
2 participants
@QuintinWillison @davyskiba