Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Add integration tests for official plugins #3

Open
pantharshit00 opened this issue Sep 30, 2020 · 2 comments
Open

Add integration tests for official plugins #3

pantharshit00 opened this issue Sep 30, 2020 · 2 comments

Comments

@pantharshit00
Copy link
Member

Right now the official abell plugins are not tested at all and it would be great if we can add some integration tests there so that we can build more confidence when we change the renderer code.

I also found that they also lack unit tests per plugin which should also be added but I will value these tests more for now.

Official plugin repo: https://github.com/abelljs/official-plugins

More context: abelljs/abell#77 (comment)

@saurabhdaware
Copy link
Member

We can add tests for afterBuild first in https://github.com/abelljs/abell/blob/main/examples/with-plugin/with-plugin.spec.js and test integrations in this same repository.

Later we can unit test the official-plugins repo for the plugin-specific functions.

@saurabhdaware
Copy link
Member

abelljs/abell#77 (comment)

Yup this makes sense. Always better to have more tests. Moving this issue to official-plugins repository.

@saurabhdaware saurabhdaware transferred this issue from abelljs/abell Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants