Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour (missed installs) in rare cases of coexisting multiple instances of latest VC++ #118

Open
TemporaryAl opened this issue Dec 3, 2024 · 3 comments

Comments

@TemporaryAl
Copy link

I am used to running this tool in general to make sure I am set with the latest versions at any point.

Earlier today Steam auto-installed the current (14.42.34433) runtimes, in the combined (not Min+Add) version, along the already installed split ones of the same version I already had from running this tool a week ago. Now, I am not here to report the wrong Steam behaviour, however...

My thought was to just run this tool again quickly to make sure it sorted that situation out, but after uninstalling both the combined runtimes (which made all 2+4 entries disappear from the installed apps list) it only reinstalled the split X64 packages.

I gather the disappearance of everything from the app list is probably linked to the split packages getting removed along with the removal of the combined ones, and don't know if there's any way to prevent that, but the tool should at least reinstall all 4 split packages (X64+X86) in such case.

@abbodi1406
Copy link
Owner

It should, but sometimes not all scenarios or detection routines work as expected

if you can reproduce the same steps, but instead running the AIO again in install mode, run in debug mode

@TemporaryAl
Copy link
Author

TemporaryAl commented Dec 3, 2024

1VCpp_Debug.log

I guess I should add that running the tool a second time does then add the two missing split X86 packages. But running it twice is silly.

@abbodi1406
Copy link
Owner

abbodi1406 commented Dec 4, 2024

I think i found the culprit

the script order on x64 system:

  • detect split msi packages for x86
  • detect combined WiX packages
  • uninstall WiX packages if any
  • detect msi packages for x64
  • install missing msi packages for all

because x86 packages are detected first, the script see them as already installed, so it doesn't attempt to reinstall
even though they get uninstalled later when uninstalling combined packages

previously in v82 and eariler, WiX packages were detected and uninstalled first
but to support Repair and Update modes, i had to detect x86 packages first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants