We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a mismatch in the parameter order and a missing parameter in the super().init() call within the OrbitalPW class in orb_pw.py.
super().init()
OrbitalPW
orb_pw.py
In the OrbitalPW.init() method, the parameters are defined as:
OrbitalPW.init()
def init(self, srcdir, nzmax, nzshift, diagnosis=True):
However, the call to the parent class's init method is:
init
coefs_default = super().init(srcdir, nzshift, diagnosis)
This call omits the required nzmax parameter and passes nzshift in the wrong position.
nzmax
nzshift
The parent class Orbital.init() in orb.py has the signature:
Orbital.init()
orb.py
def init(self, srcdir, nzshift, diagnosis=True):
Please refer to the discussion for more details: kirk0830#107 (comment)
Reported by @coderabbitai.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
There is a mismatch in the parameter order and a missing parameter in the
super().init()
call within theOrbitalPW
class inorb_pw.py
.In the
OrbitalPW.init()
method, the parameters are defined as:However, the call to the parent class's
init
method is:This call omits the required
nzmax
parameter and passesnzshift
in the wrong position.The parent class
Orbital.init()
inorb.py
has the signature:Please refer to the discussion for more details:
kirk0830#107 (comment)
Reported by @coderabbitai.
The text was updated successfully, but these errors were encountered: