Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter order and missing parameter in super().init() call in 'orb_pw.py' #13

Open
coderabbitai bot opened this issue Nov 24, 2024 · 0 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2024

There is a mismatch in the parameter order and a missing parameter in the super().init() call within the OrbitalPW class in orb_pw.py.

In the OrbitalPW.init() method, the parameters are defined as:

def init(self, srcdir, nzmax, nzshift, diagnosis=True):

However, the call to the parent class's init method is:

coefs_default = super().init(srcdir, nzshift, diagnosis)

This call omits the required nzmax parameter and passes nzshift in the wrong position.

The parent class Orbital.init() in orb.py has the signature:

def init(self, srcdir, nzshift, diagnosis=True):

Please refer to the discussion for more details:
kirk0830#107 (comment)

Reported by @coderabbitai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants